From: David Miller <davem@davemloft.net>
To: vincentc@andestech.com
Cc: gregkh@linuxfoundation.org, rdunlap@infradead.org,
yuehaibing@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts
Date: Tue, 20 Nov 2018 10:28:43 -0800 (PST) [thread overview]
Message-ID: <20181120.102843.2033247081781930217.davem@davemloft.net> (raw)
In-Reply-To: <1542692266-17720-1-git-send-email-vincentc@andestech.com>
aFrom: Vincent Chen <vincentc@andestech.com>
Date: Tue, 20 Nov 2018 13:37:46 +0800
> + /* Disable interrupts for polling */
> + ftmac100_disable_all_int(priv);
> if (likely(netif_running(netdev))) {
> - /* Disable interrupts for polling */
> - ftmac100_disable_all_int(priv);
> napi_schedule(&priv->napi);
> }
This is now a single-line basic block, so please remove the curly
braces.
Thank you.
next prev parent reply other threads:[~2018-11-20 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 5:37 Vincent Chen
2018-11-20 18:28 ` David Miller [this message]
2018-11-21 0:49 ` Vincent Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120.102843.2033247081781930217.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vincentc@andestech.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®