From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CABC43441 for ; Wed, 21 Nov 2018 11:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54299214C1 for ; Wed, 21 Nov 2018 11:17:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="0ni2Wjio" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54299214C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730123AbeKUVvv (ORCPT ); Wed, 21 Nov 2018 16:51:51 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:35758 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729746AbeKUVvu (ORCPT ); Wed, 21 Nov 2018 16:51:50 -0500 Received: by mail-pl1-f196.google.com with SMTP id v1-v6so5111967plo.2 for ; Wed, 21 Nov 2018 03:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gtI0f44QcPc2Xq5kFshuAlZz3u47ZnSz0q4zjTQxm0A=; b=0ni2WjiooTFDxKhS5rl1tYQRDRTnEdAUAeIH7EfFKhE4SgV992QwSSLoyuZqq8KuMH chDSca/ZxAYobGu0NKPz3f05TS//9/V210pNUmRcEfWNLJ/nbcm5j0bTtQ48NQnUNiKI v6og87ttJdKPnnVF8Q5qrDLUzyzJAyXt/NTKdKiInzNZl3Fq5UtW3Qgqn3c3VL5BS5cW UhV9Kij0Gok00XhCUIQIvI15sfn5kHZkr84/6c8oT4d2vDYeQEnQuh/uzCgG5uffEj8j 8KARAzPN/MssI5RCNz/s+B+e26+xdV45LELqI0KDtSi/aE0ZzuN1XGuYiKvRc8rljlTJ 6ndg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gtI0f44QcPc2Xq5kFshuAlZz3u47ZnSz0q4zjTQxm0A=; b=A3YL0QM9riOMmpQ2wCu2ecdUdbZ9YWtZVDmzJYGlnVck47AXMSZgZ0ni1t8bQfU3+D xxNRgqiE82v2qp26bpQvpdbn/Naeof2CUCio2FRX1vXpk40C2hY/NTnKR8chRjRjtNzw 5h+XpkT7MyG/OMwpYmazR0KmziE6Q0fXI2Kz0hdgdndIt72nk9l+fJRWHihswrTQuERZ 2BwgedT4wJRjKxFCF9W/cAjbWlVpix5mj+5SgjYakpvev14yN4dYQ3wnwoeW3/j/FetH 0KPHe+J9FhrvMD04QbVV6jYqITHVUeZMiW97s57ptJT+6kM8Rgewd8BqAiWzDEkeClDN sT8g== X-Gm-Message-State: AA+aEWaISwgoA0woxuuIwn3DwjwvPzqX21AQdsDVUPv/db/nQQOgEGoD nnC7RjwtrOHyT+uoO8oLQMjTaQ== X-Google-Smtp-Source: AFSGD/WtBzdbF08Uv8v+oq4AAHGOywy1cVqHE3nwuHdBUZQS4zOuqtVT6mbIRNJQJURjfykWqLVtLw== X-Received: by 2002:a63:ea15:: with SMTP id c21mr5287592pgi.361.1542799070336; Wed, 21 Nov 2018 03:17:50 -0800 (PST) Received: from kshutemo-mobl1.localdomain ([192.55.54.42]) by smtp.gmail.com with ESMTPSA id h7-v6sm73985110pfd.35.2018.11.21.03.17.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Nov 2018 03:17:49 -0800 (PST) Received: by kshutemo-mobl1.localdomain (Postfix, from userid 1000) id A1B89302652; Wed, 21 Nov 2018 14:17:45 +0300 (+03) Date: Wed, 21 Nov 2018 14:17:45 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: kernel test robot , Waiman Long , Matthew Wilcox , Andrew Morton , Linux Memory Management List , linux-kernel@vger.kernel.org, LKP , Michal Hocko , Vlastimil Babka Subject: Re: [LKP] dd2283f260 [ 97.263072] WARNING:at_kernel/locking/lockdep.c:#lock_downgrade Message-ID: <20181121111745.v56gygpfn5gvdoc4@kshutemo-mobl1> References: <20181115055443.GF18977@shao2-debian> <20181120085749.lj7dzk52633oq42s@kshutemo-mobl1> <9dec33d0-f408-8428-b004-fa63fc2e9091@linux.alibaba.com> <20181120134216.s5derazwpay5gkfk@kshutemo-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 21, 2018 at 08:35:28AM +0800, Yang Shi wrote: > > > On 11/20/18 9:42 PM, Kirill A. Shutemov wrote: > > On Tue, Nov 20, 2018 at 08:10:51PM +0800, Yang Shi wrote: > > > > > > On 11/20/18 4:57 PM, Kirill A. Shutemov wrote: > > > > On Fri, Nov 16, 2018 at 08:56:04AM -0800, Yang Shi wrote: > > > > > > a8dda165ec vfree: add debug might_sleep() > > > > > > dd2283f260 mm: mmap: zap pages with read mmap_sem in munmap > > > > > > 5929a1f0ff Merge tag 'riscv-for-linus-4.20-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/palmer/riscv-linux > > > > > > 0bc80e3cb0 Add linux-next specific files for 20181114 > > > > > > +-----------------------------------------------------+------------+------------+------------+---------------+ > > > > > > | | a8dda165ec | dd2283f260 | 5929a1f0ff | next-20181114 | > > > > > > +-----------------------------------------------------+------------+------------+------------+---------------+ > > > > > > | boot_successes | 314 | 178 | 190 | 168 | > > > > > > | boot_failures | 393 | 27 | 21 | 40 | > > > > > > | WARNING:held_lock_freed | 383 | 23 | 17 | 39 | > > > > > > | is_freeing_memory#-#,with_a_lock_still_held_there | 383 | 23 | 17 | 39 | > > > > > > | BUG:unable_to_handle_kernel | 5 | 2 | 4 | 1 | > > > > > > | Oops:#[##] | 9 | 3 | 4 | 1 | > > > > > > | EIP:debug_check_no_locks_freed | 9 | 3 | 4 | 1 | > > > > > > | Kernel_panic-not_syncing:Fatal_exception | 9 | 3 | 4 | 1 | > > > > > > | Mem-Info | 4 | 1 | | | > > > > > > | invoked_oom-killer:gfp_mask=0x | 1 | 1 | | | > > > > > > | WARNING:at_kernel/locking/lockdep.c:#lock_downgrade | 0 | 6 | 4 | 7 | > > > > > > | EIP:lock_downgrade | 0 | 6 | 4 | 7 | > > > > > > +-----------------------------------------------------+------------+------------+------------+---------------+ > > > > > > > > > > > > [ 96.288009] random: get_random_u32 called from arch_rnd+0x3c/0x70 with crng_init=0 > > > > > > [ 96.359626] input_id (331) used greatest stack depth: 6360 bytes left > > > > > > [ 96.749228] grep (358) used greatest stack depth: 6336 bytes left > > > > > > [ 96.921470] network.sh (341) used greatest stack depth: 6212 bytes left > > > > > > [ 97.262340] > > > > > > [ 97.262587] ========================= > > > > > > [ 97.263072] WARNING: held lock freed! > > > > > > [ 97.263536] 4.19.0-06969-gdd2283f #1 Not tainted > > > > > > [ 97.264110] ------------------------- > > > > > > [ 97.264575] udevd/198 is freeing memory 9c16c930-9c16c99b, with a lock still held there! > > > > > > [ 97.265542] (ptrval) (&anon_vma->rwsem){....}, at: unlink_anon_vmas+0x14e/0x420 > > > > > > [ 97.266450] 1 lock held by udevd/198: > > > > > > [ 97.266924] #0: (ptrval) (&mm->mmap_sem){....}, at: __do_munmap+0x531/0x730 > > > > > I have not figured out what this is caused by. But, the below warning looks > > > > > more confusing. This might be caused by the below one. > > > > I *think* we need to understand more about what detached VMAs mean for > > > > rmap. The anon_vma for these VMAs still reachable for the rmap and > > > > therefore VMA too. I don't quite grasp what is implications of this, but > > > > it doesn't look good. > > > I'm supposed before accessing anon_vma, VMA need to be found by find_vma() > > > first, right? But, finding VMA need hold mmap_sem, once detach VMAs is > > > called, others should not be able to find the VMAs anymore. So, the anon_vma > > > should not be reachable except the munmap caller. > > No. anon_vma can be reached from page->mapping. The page can be reached > > during physcal memory scan or if the page is shared (across fork()). None > > of these accesses require mmap_sem. > > If they don't require mmap_sem at all, this problem should be valid > regardless of the optimization. We just downgraded write mmap_sem to read, > but still hold it. I tend to agree with you. But having the crash in the picture makes me wounder if there's scenario when VMA reachable via anon_vma, but not via find_vma() causes a problem. I cannot think of any, but who knows. -- Kirill A. Shutemov