From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 0/4] device property: Add fwnode_get_name() helper
Date: Wed, 21 Nov 2018 14:36:37 +0200 [thread overview]
Message-ID: <20181121123637.GB26377@kuha.fi.intel.com> (raw)
In-Reply-To: <4687553.lNXoFSueqb@aspire.rjw.lan>
On Tue, Nov 20, 2018 at 11:03:45PM +0100, Rafael J. Wysocki wrote:
> On Thursday, November 8, 2018 5:51:52 PM CET Heikki Krogerus wrote:
> > Hi,
> >
> > This is the second version of my proposal for this helper. The
> > first version can be checked here:
> > https://lkml.org/lkml/2018/11/5/326
> >
> > In order to support also ACPI properly, I decided to change the API.
> > The function fwnode_name() is now fwnode_get_name(), and instead of
> > returning pointer to the name, the function copies it to a buffer. I
> > did that because acpica does not offer a way to get a pointer to the
> > node name, and the name is clearly expected to be accessed only with
> > the namespace lock held.
> >
> > I think this is better approach in any case. It will also solve the
> > problem of getting rid of the unit-address part from DT node names.
> >
> > Let me know what you guys think.
> >
> > --
> > heikki
> >
> >
> > Heikki Krogerus (4):
> > device property: Introduce fwnode_get_name()
> > ACPI: property: Add acpi_fwnode_name()
> > of/property: Add of_fwnode_name()
> > device property: Drop get_named_child_node callback
> >
> > drivers/acpi/property.c | 43 ++++++++++++++++++++++------------------
> > drivers/base/property.c | 34 ++++++++++++++++++++++++++++++-
> > drivers/of/property.c | 26 ++++++++++--------------
> > include/linux/fwnode.h | 6 +++---
> > include/linux/property.h | 2 ++
> > 5 files changed, 73 insertions(+), 38 deletions(-)
> >
> >
>
> I will be expecting at least one more iteration of this series to address the
> Rob's comments.
Yes, I'll send a new version soon.
thanks,
--
heikki
prev parent reply other threads:[~2018-11-21 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 16:51 Heikki Krogerus
2018-11-08 16:51 ` [PATCH v2 1/4] device property: Introduce fwnode_get_name() Heikki Krogerus
2018-11-08 16:51 ` [PATCH v2 2/4] ACPI: property: Add acpi_fwnode_name() Heikki Krogerus
2018-11-08 16:51 ` [PATCH v2 3/4] of/property: Add of_fwnode_name() Heikki Krogerus
2018-11-08 18:23 ` Rob Herring
2018-11-08 19:25 ` Andy Shevchenko
2018-11-08 21:18 ` Rob Herring
2018-11-09 13:34 ` Heikki Krogerus
2018-11-09 16:14 ` Rob Herring
2018-11-12 15:05 ` Heikki Krogerus
2018-11-08 16:51 ` [PATCH v2 4/4] device property: Drop get_named_child_node callback Heikki Krogerus
2018-11-20 22:03 ` [PATCH v2 0/4] device property: Add fwnode_get_name() helper Rafael J. Wysocki
2018-11-21 12:36 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121123637.GB26377@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®