Re: [PATCH V2] thermal: imx: fix for dependency on cpu-freq

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1654 bytes --]

Hi Anson,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on soc-thermal/next]
[also build test WARNING on v4.20-rc3 next-20181120]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anson-Huang/thermal-imx-fix-for-dependency-on-cpu-freq/20181121-124056
base:   https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git next
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   drivers//thermal/imx_thermal.c: In function 'imx_thermal_unregister_legacy_cooling':
>> drivers//thermal/imx_thermal.c:685:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^

vim +685 drivers//thermal/imx_thermal.c

   680	
   681	static int imx_thermal_unregister_legacy_cooling(struct imx_thermal_data *data)
   682	{
   683		cpufreq_cooling_unregister(data->cdev);
   684		cpufreq_cpu_put(data->policy);
 > 685	}
   686	#else
   687	static inline int imx_thermal_register_legacy_cooling(struct imx_thermal_data *data)
   688	{
   689		return 0;
   690	}
   691	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55093 bytes --]