From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Tudor.Ambarus@microchip.com, marek.vasut@gmail.com,
dwmw2@infradead.org, computersforpeace@gmail.com,
boris.brezillon@bootlin.com, richard@nod.at,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [v2] mtd: spi-nor: fix selection of uniform erase type in flexible conf
Date: Wed, 21 Nov 2018 15:33:43 +0100 [thread overview]
Message-ID: <20181121143343.11330-1-boris.brezillon@bootlin.com> (raw)
In-Reply-To: <20181116174624.10817-1-tudor.ambarus@microchip.com>
On Fri, 2018-11-16 at 17:46:37 UTC, wrote:
> There are uniform, non-uniform and flexible erase flash configurations.
>
> The non-uniform erase types, are the erase types that can _not_ erase
> the entire flash by their own.
>
> As the code was, in case flashes had flexible erase capabilities
> (support both uniform and non-uniform erase types in the same flash
> configuration) and supported multiple uniform erase type sizes, the
> code did not sort the uniform erase types, and could select a wrong
> erase type size.
>
> Sort the uniform erase mask in case of flexible erase flash
> configurations, in order to select the best uniform erase type size.
>
> Uniform, non-uniform, and flexible configurations with just a valid
> uniform erase type, are not affected by this change.
>
> Uniform erase tested on mx25l3273fm2i-08g and sst26vf064B-104i/sn.
> Non uniform erase tested on sst26vf064B-104i/sn.
>
> Fixes: 5390a8df769e ("mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Applied to http://git.infradead.org/linux-mtd.git master, thanks.
Boris
prev parent reply other threads:[~2018-11-21 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 11:17 [PATCH] " Tudor.Ambarus
2018-11-16 17:36 ` Tudor.Ambarus
2018-11-16 17:46 ` [PATCH v2] " Tudor.Ambarus
2018-11-21 14:33 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121143343.11330-1-boris.brezillon@bootlin.com \
--to=boris.brezillon@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®