From: Andrew Morton <akpm@linux-foundation.org>
To: danielijrobson@gmail.com
Cc: dbueso@suse.de, manfred@colorfullife.com, ebiederm@xmission.com,
mike.kravetz@oracle.com, linux@dominikbrodowski.net,
viro@zeniv.linux.org.uk, ebiggers@google.com, arnd@arndb.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipc/shm.c: removed 'int err' from shm_get_policy()
Date: Wed, 21 Nov 2018 21:07:30 -0800 [thread overview]
Message-ID: <20181121210730.f820f51d03d1171d4319dc30@linux-foundation.org> (raw)
In-Reply-To: <20181118234911.17697-1-danielijrobson@gmail.com>
On Sun, 18 Nov 2018 23:49:11 +0000 danielijrobson@gmail.com wrote:
> removed unneeded variable in shm_get_policy()
>
> ...
>
> --- a/ipc/shm.c
> +++ b/ipc/shm.c
> @@ -461,11 +461,10 @@ static int shm_set_policy(struct vm_area_struct *vma, struct mempolicy *new)
> {
> struct file *file = vma->vm_file;
> struct shm_file_data *sfd = shm_file_data(file);
> - int err = 0;
>
> if (sfd->vm_ops->set_policy)
> - err = sfd->vm_ops->set_policy(vma, new);
> - return err;
> + return sfd->vm_ops->set_policy(vma, new);
> + return 0;
> }
Sorry, I don't think this is enough of an improvement to justify adding
the patch.
prev parent reply other threads:[~2018-11-22 5:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 23:49 danielijrobson
2018-11-22 5:07 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121210730.f820f51d03d1171d4319dc30@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=danielijrobson@gmail.com \
--cc=dbueso@suse.de \
--cc=ebiederm@xmission.com \
--cc=ebiggers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=manfred@colorfullife.com \
--cc=mike.kravetz@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome