From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>,
Josh Triplett <josh@joshtriplett.org>,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org, NeilBrown <neilb@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>, Crt Mori <cmo@melexis.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse
Date: Thu, 22 Nov 2018 15:32:02 +0100 [thread overview]
Message-ID: <20181122143201.d7vifhlny7gmrhzd@ltop.local> (raw)
In-Reply-To: <1542856462-18836-1-git-send-email-yamada.masahiro@socionext.com>
On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote:
> When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot
> reported lots of "unknown expression" warnings from container_of(),
> which seemed false positive.
>
> I addressed this in [1], but fixing Sparse is the right thing to do.
>
> The issue was fixed by Sparse commit 0eb8175d3e9c ("fix expansion of
> function designator"), but it will take time until the fixed version
> of Sparse is widely available.
>
> Disable the container_of() type checks for Sparse for now.
I would prefer that developers upgrade their version of sparse but ...
Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
next prev parent reply other threads:[~2018-11-22 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 3:14 Masahiro Yamada
2018-11-22 3:14 ` [PATCH v4 2/3] build_bug.h: remove negative-array fallback for BUILD_BUG_ON() Masahiro Yamada
2018-11-24 8:16 ` Miguel Ojeda
2018-11-22 3:14 ` [PATCH v4 3/3] build_bug.h: remove most of dummy BUILD_BUG_ON stubs for Sparse Masahiro Yamada
2018-11-24 8:29 ` Miguel Ojeda
2018-11-22 3:25 ` [PATCH v4 1/3] kernel.h: disable type-checks in container_of() " Andrew Morton
2018-11-22 14:32 ` Luc Van Oostenryck [this message]
2018-11-24 8:24 ` Miguel Ojeda
2018-11-25 13:56 ` Masahiro Yamada
2018-12-01 3:34 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122143201.d7vifhlny7gmrhzd@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=cmo@melexis.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=neilb@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®