From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CCCC43441 for ; Thu, 22 Nov 2018 15:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9AC3206B2 for ; Thu, 22 Nov 2018 15:48:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9AC3206B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437835AbeKWC2Z (ORCPT ); Thu, 22 Nov 2018 21:28:25 -0500 Received: from mail.bootlin.com ([62.4.15.54]:33021 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728825AbeKWC2Z (ORCPT ); Thu, 22 Nov 2018 21:28:25 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 73A432072F; Thu, 22 Nov 2018 16:48:29 +0100 (CET) Received: from localhost (aaubervilliers-681-1-94-205.w90-88.abo.wanadoo.fr [90.88.35.205]) by mail.bootlin.com (Postfix) with ESMTPSA id 3D26620726; Thu, 22 Nov 2018 16:48:19 +0100 (CET) Date: Thu, 22 Nov 2018 16:48:19 +0100 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , devicetree , Linux-ALSA , linux-arm-kernel , linux-kernel , linux-sunxi@googlegroups.com, Vasily Khoruzhick Subject: Re: [PATCH v9 1/8] ASoC: dt-bindings: sun50i-codec-analog: Add headphone amp regulator supply Message-ID: <20181122154819.powgbwwqpljqvjty@flea> References: <20181122102325.29495-1-wens@csie.org> <20181122102325.29495-2-wens@csie.org> <20181122153241.lzrwhkewg5q4hy2c@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5hmfxjc2ebpbwox7" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5hmfxjc2ebpbwox7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 22, 2018 at 11:41:57PM +0800, Chen-Yu Tsai wrote: > On Thu, Nov 22, 2018 at 11:33 PM Maxime Ripard > wrote: > > > > On Thu, Nov 22, 2018 at 06:23:18PM +0800, Chen-Yu Tsai wrote: > > > On the Allwinner A64 SoC, the audio codec has a built-in headphone > > > amplifier. This amplifier has a power supply separate from the rest of > > > the analog audio circuitry. > > > > > > Add a regulator supply property to handle this. > > > > > > Signed-off-by: Chen-Yu Tsai > > > --- > > > Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt | 2 = ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/sound/sun50i-codec-ana= log.txt b/Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt > > > index 4f8ad0e04d20..056a098495cc 100644 > > > --- a/Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt > > > +++ b/Documentation/devicetree/bindings/sound/sun50i-codec-analog.txt > > > @@ -4,9 +4,11 @@ Required properties: > > > - compatible: must be one of the following compatibles: > > > - "allwinner,sun50i-a64-codec-analog" > > > - reg: must contain the registers location and length > > > +- cpvdd-supply: Regulator supply for the headphone amplifier > > > > I guess we should make this optional, since even if it's missing, it's > > going to create a dummy regulator. and that allows to have backward > > compatibility. > > > > For the rest of the series, > > Acked-by: Maxime Ripard >=20 > This one (not sun8i-codec-analog) is new for the next release, so there's > no backward compatibility to consider. Plus none of the device tree chang= es > for A64 have been merged. Ok, that works for me then. Thanks! Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --5hmfxjc2ebpbwox7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCW/bPwwAKCRDj7w1vZxhR xaOXAPoDGA+MHdwPvd+MImeN7h7bZ2dIN4W3GQ9BhADO6k/3cwD/fkshEBfLZBVa 8na4WisOHg5bCOOLHk1GzDZoHZmstgs= =suhd -----END PGP SIGNATURE----- --5hmfxjc2ebpbwox7--