mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Alexander.Onnasch@landisgyr.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net] phy: Micrel KSZ8061: link failure after cable connect
Date: Fri, 23 Nov 2018 22:23:51 -0800 (PST)	[thread overview]
Message-ID: <20181123.222351.996887956213237908.davem@davemloft.net> (raw)
In-Reply-To: <1542965762-26822-1-git-send-email-alexander.onnasch@landisgyr.com>

From: "Onnasch, Alexander (EXT)" <Alexander.Onnasch@landisgyr.com>
Date: Fri, 23 Nov 2018 09:36:11 +0000

> With Micrel KSZ8061 PHY, the link may occasionally not come up after
> Ethernet cable connect. The vendor's (Microchip, former Micrel) errata
> sheet 80000688A.pdf describes the problem and possible workarounds in
> detail, see below.
> The patch implements workaround 1, which permanently fixes the issue.
 ...
> Signed-off-by: Alexander Onnasch <alexander.onnasch@landisgyr.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Something is off with your character encodings or something like that.

When I download your patch from patchwork, I see every line end with
a ^M control character.  See for yourself:

	https://patchwork.ozlabs.org/patch/1002221/mbox/

You'll need to fix this before I can apply your patch.

  parent reply	other threads:[~2018-11-24  6:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23  9:36 Onnasch, Alexander (EXT)
2018-11-23 15:00 ` Andrew Lunn
2018-11-24  6:23 ` David Miller [this message]
2019-02-01 10:48 Rajasingh Thavamani
2019-02-01 18:17 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123.222351.996887956213237908.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Alexander.Onnasch@landisgyr.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®