From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E88FC43441 for ; Fri, 23 Nov 2018 12:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5945F20672 for ; Fri, 23 Nov 2018 12:54:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5945F20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504452AbeKWXiI (ORCPT ); Fri, 23 Nov 2018 18:38:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:39508 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2405545AbeKWXiI (ORCPT ); Fri, 23 Nov 2018 18:38:08 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 11DDDABE3; Fri, 23 Nov 2018 12:54:02 +0000 (UTC) Date: Fri, 23 Nov 2018 13:54:00 +0100 From: Michal Hocko To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Andrew Morton , Dan Williams , Oscar Salvador , Pavel Tatashin , Joonsoo Kim , Arun KS , Mathieu Malaterre , Stephen Rothwell Subject: Re: [PATCH v1] mm/memory_hotplug: drop "online" parameter from add_memory_resource() Message-ID: <20181123125400.GL8625@dhcp22.suse.cz> References: <20181123123740.27652-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181123123740.27652-1-david@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 23-11-18 13:37:40, David Hildenbrand wrote: > User space should always be in charge of how to online memory and > if memory should be onlined automatically in the kernel. Let's drop the > parameter to overwrite this - XEN passes memhp_auto_online, just like > add_memory(), so we can directly use that instead internally. Heh, I wanted to get rid of memhp_auto_online so much and now we have it in the core memory_hotplug. Not a win on my side I would say :/ On the other hand this can be seen as a cleanup because it removes that ambiguity that some callers might be unaware of the memhp_auto_online leading to a different behavior. > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Stefano Stabellini > Cc: Andrew Morton > Cc: Dan Williams > Cc: Oscar Salvador > Cc: Pavel Tatashin > Cc: Michal Hocko > Cc: David Hildenbrand > Cc: Joonsoo Kim > Cc: Arun KS > Cc: Mathieu Malaterre > Cc: Stephen Rothwell > Signed-off-by: David Hildenbrand Acked-by: Michal Hocko -- Michal Hocko SUSE Labs