From: Otavio Salvador <otavio@ossystems.com.br>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: Otavio Salvador <otavio@ossystems.com.br>,
Fabio Berton <fabio.berton@ossystems.com.br>,
Jose Abreu <joabreu@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
netdev@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 04/13] net: stmmac: dwmac-rk: Do not print redundant error message
Date: Sun, 25 Nov 2018 19:18:58 -0200 [thread overview]
Message-ID: <20181125211907.9895-4-otavio@ossystems.com.br> (raw)
In-Reply-To: <20181125211907.9895-1-otavio@ossystems.com.br>
rk_gmac_setup() already prints a message saying that the PHY regulator
is not found, so we should not print it again.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 73855622445b..c895a9a6939a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -1203,10 +1203,8 @@ static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
int ret;
struct device *dev = &bsp_priv->pdev->dev;
- if (!ldo) {
- dev_err(dev, "no regulator found\n");
+ if (!ldo)
return 0;
- }
if (enable) {
ret = regulator_enable(ldo);
--
2.19.1
next prev parent reply other threads:[~2018-11-25 21:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-25 21:18 [PATCH 01/13] ARM: multi_v7_defconfig: Select PHY_ROCKCHIP_INNO_USB2 Otavio Salvador
2018-11-25 21:18 ` [PATCH 02/13] ARM: multi_v7_defconfig: Add missing systemd options Otavio Salvador
2018-11-25 22:25 ` Olof Johansson
2018-11-25 23:10 ` Otavio Salvador
2018-11-25 21:18 ` [PATCH 03/13] net: stmmac: dwmac-rk: Allow the driver to probe when phy-supply is not present Otavio Salvador
2018-11-25 21:18 ` Otavio Salvador [this message]
2018-11-25 21:18 ` [PATCH 05/13] net: stmmac: dwmac-rk: Do not print error when PHY regulator is not found Otavio Salvador
2018-11-25 21:19 ` [PATCH 06/13] ARM: dts: rv1108: Add GMAC support Otavio Salvador
2018-11-26 9:14 ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 07/13] ARM: dts: rv1108: Fix the timer mask Otavio Salvador
2018-11-26 5:26 ` Heiko Stuebner
2018-11-26 13:45 ` Otavio Salvador
2018-11-25 21:19 ` [PATCH 08/13] ARM: dts: rv1108: Fix the PMU interrupt number Otavio Salvador
2018-11-26 5:58 ` Heiko Stuebner
2018-11-26 13:36 ` Otavio Salvador
2018-11-26 13:46 ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 09/13] ARM: dts: rv1108: Assign the proper GPIO clocks Otavio Salvador
2018-11-25 21:19 ` [PATCH 10/13] ARM: dts: rv1108: Add UART DMA support Otavio Salvador
2018-11-25 21:19 ` [PATCH 11/13] ARM: dts: rv1108: Add internal timer support Otavio Salvador
2018-11-26 8:57 ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 12/13] ARM: dts: rv1108: Pass the 'arm,cpu-registers-not-fw-configured' property Otavio Salvador
2018-11-26 9:29 ` Heiko Stuebner
2018-11-25 21:19 ` [PATCH 13/13] ARM: dts: rv1108: Pass the 'clock-latency' property Otavio Salvador
2018-11-26 9:25 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181125211907.9895-4-otavio@ossystems.com.br \
--to=otavio@ossystems.com.br \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=fabio.berton@ossystems.com.br \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®