From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61460C43441 for ; Mon, 26 Nov 2018 08:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3197220663 for ; Mon, 26 Nov 2018 08:46:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3197220663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbeKZTkU (ORCPT ); Mon, 26 Nov 2018 14:40:20 -0500 Received: from mail.bootlin.com ([62.4.15.54]:44569 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726158AbeKZTkU (ORCPT ); Mon, 26 Nov 2018 14:40:20 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 29C03207BC; Mon, 26 Nov 2018 09:46:54 +0100 (CET) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 0899E2037D; Mon, 26 Nov 2018 09:46:44 +0100 (CET) Date: Mon, 26 Nov 2018 09:46:43 +0100 From: Boris Brezillon To: Dan Carpenter Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2] ic3: master: off by one in mode_show() Message-ID: <20181126094643.6b1f05cd@bbrezillon> In-Reply-To: <20181123071505.ahhh7xqvt4eb7tt2@kili.mountain> References: <20181123071505.ahhh7xqvt4eb7tt2@kili.mountain> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Nov 2018 10:15:05 +0300 Dan Carpenter wrote: > This should be >= ARRAY_SIZE() to avoid reading one element beyond the > end of the array. > > Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") > Signed-off-by: Dan Carpenter Queued to i3c/next. Thanks, Boris > --- > drivers/i3c/master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index bda4b9613e53..c39f89d2deba 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -475,7 +475,7 @@ static ssize_t mode_show(struct device *dev, > > i3c_bus_normaluse_lock(i3cbus); > if (i3cbus->mode < 0 || > - i3cbus->mode > ARRAY_SIZE(i3c_bus_mode_strings) || > + i3cbus->mode >= ARRAY_SIZE(i3c_bus_mode_strings) || > !i3c_bus_mode_strings[i3cbus->mode]) > ret = sprintf(buf, "unknown\n"); > else