From: Andrew Morton <akpm@linux-foundation.org>
To: Feng Tang <feng.tang@intel.com>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <john.stultz@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC PATCH] panic: Add options to dump system info when panic happens
Date: Mon, 26 Nov 2018 15:24:57 -0800 [thread overview]
Message-ID: <20181126152457.42f9917138e02b4ab9f17f7b@linux-foundation.org> (raw)
In-Reply-To: <1542870631-77074-1-git-send-email-feng.tang@intel.com>
On Thu, 22 Nov 2018 15:10:31 +0800 Feng Tang <feng.tang@intel.com> wrote:
> Kernel panic issues are always painful to debug, partially
> because of it's not easy to get enough information of the
> context when panic happens.
>
> And we have ramoops and kdump for that, while this commit
> tries to a easier way to show the system info by adding a
> cmdline parameter, referring some idea from sysrq handler.
>
This seems sensible to me.
> This patch is frequently used by us when debugging panic and system
> stability bugs, and does help much. And the options could be expanded
> more to cover other info like the ftrace, signal etc.
And that info is valuable.
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3081,6 +3081,13 @@
> timeout < 0: reboot immediately
> Format: <timeout>
>
> + panic_dump= Bitmask for dumping system info when panic happens.
> + User can chose combination of the following bits:
> + bit 0: dump all tasks info
> + bit 1: dump system memory info
> + bit 2: dump timer info
> + bit 3: dump locks info if CONFIG_LOCKDEP is on
> +
Using "dump" makes this feature sounds a bit like kdump, which is also
used in this code context.
I think I'd prefer that we use "print" - that's a more accurate
description and avoids such confusion. So s/dump/print/ and
s/DUMP/PRINT/ throughout the changelog and patch?
next prev parent reply other threads:[~2018-11-26 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 7:10 Feng Tang
2018-11-26 23:24 ` Andrew Morton [this message]
2018-11-27 2:16 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126152457.42f9917138e02b4ab9f17f7b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=feng.tang@intel.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®