From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE5DC43441 for ; Mon, 26 Nov 2018 15:47:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B96620855 for ; Mon, 26 Nov 2018 15:47:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="cJIAxP+b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B96620855 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbeK0Clh (ORCPT ); Mon, 26 Nov 2018 21:41:37 -0500 Received: from mail.skyhub.de ([5.9.137.197]:42532 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbeK0Clh (ORCPT ); Mon, 26 Nov 2018 21:41:37 -0500 Received: from zn.tnic (p200300EC2BDEFE00DCA0409AA15535E1.dip0.t-ipconnect.de [IPv6:2003:ec:2bde:fe00:dca0:409a:a155:35e1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AA0751EC040F; Mon, 26 Nov 2018 16:47:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1543247226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JQ8trMYIO69IReuA3dsQ+KhDlVyQE3d29esROZCBGnI=; b=cJIAxP+bHSl5cochl2xUA/PXqdUFPKMWlm0/1vPhRS2eTe6b4ih1DHZpR2XM1pUzCpoG7L 2oakXbXiLJx6DPw7fQVqcnUtIa+AEjEVE1IhcgJ4e+wKkprq9mtgJZwD70bJ27OOI00jfw yapxtSVDnMHUhY9XPcFC1weVQ5JgFLU= Date: Mon, 26 Nov 2018 16:47:01 +0100 From: Borislav Petkov To: Thomas Gleixner Cc: LKML , x86@kernel.org, Peter Zijlstra , Andy Lutomirski , Linus Torvalds , Jiri Kosina , Tom Lendacky , Josh Poimboeuf , Andrea Arcangeli , David Woodhouse , Tim Chen , Andi Kleen , Dave Hansen , Casey Schaufler , Asit Mallick , Arjan van de Ven , Jon Masters , Waiman Long , Greg KH , Dave Stewart , Kees Cook Subject: Re: [patch V2 07/28] x86/speculation: Reorganize speculation control MSRs update Message-ID: <20181126154701.GF4843@zn.tnic> References: <20181125183328.318175777@linutronix.de> <20181125185004.151077005@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181125185004.151077005@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 25, 2018 at 07:33:35PM +0100, Thomas Gleixner wrote: > The logic to detect whether there's a change in the previous and next > task's flag relevant to update speculation control MSRs are spread out s/are/is/ > across multiple functions. > > Consolidate all checks needed for updating speculation control MSRs into > the new __speculation_ctrl_update() helper function. > > This makes it easy to pick the right speculation control MSR and the bits > in the MSR that needs updating based on TIF flags changes. s/needs/need/ -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.