From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD14C43441 for ; Tue, 27 Nov 2018 00:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D21C8208E7 for ; Tue, 27 Nov 2018 00:20:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D21C8208E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727975AbeK0LQr (ORCPT ); Tue, 27 Nov 2018 06:16:47 -0500 Received: from mail.us.es ([193.147.175.20]:57014 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726888AbeK0LQr (ORCPT ); Tue, 27 Nov 2018 06:16:47 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id AD865EDB11 for ; Tue, 27 Nov 2018 01:20:49 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 9CE70DA4D0 for ; Tue, 27 Nov 2018 01:20:49 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 928ABDA4C7; Tue, 27 Nov 2018 01:20:49 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B250BDA4C8; Tue, 27 Nov 2018 01:20:47 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 27 Nov 2018 01:20:47 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 78A804265A31; Tue, 27 Nov 2018 01:20:47 +0100 (CET) Date: Tue, 27 Nov 2018 01:20:47 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Christian Brauner Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, tyhicks@canonical.com, kadlec@blackhole.kfki.hu, fw@strlen.de, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com Subject: Re: [PATCH net-next 1/2] br_netfilter: add struct netns_brnf Message-ID: <20181127002047.7jzpfy32oupsthtj@salvia> References: <20181107134859.19896-1-christian@brauner.io> <20181107134859.19896-2-christian@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181107134859.19896-2-christian@brauner.io> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Nov 07, 2018 at 02:48:58PM +0100, Christian Brauner wrote: [...] > diff --git a/include/net/netns/netfilter.h b/include/net/netns/netfilter.h > index ca043342c0eb..eedbd1ac940e 100644 > --- a/include/net/netns/netfilter.h > +++ b/include/net/netns/netfilter.h > @@ -35,4 +35,20 @@ struct netns_nf { > bool defrag_ipv6; > #endif > }; > + > +struct netns_brnf { > +#ifdef CONFIG_SYSCTL > + struct ctl_table_header *ctl_hdr; > +#endif > + > + /* default value is 1 */ > + int call_iptables; > + int call_ip6tables; > + int call_arptables; > + > + /* default value is 0 */ > + int filter_vlan_tagged; > + int filter_pppoe_tagged; > + int pass_vlan_indev; > +}; I have spun on this several times, wondering if there's a way to avoid scratching these many bytes per netns to expose these sysctl entries that are plain on/off toggles... You said this: >Currently, the /proc/sys/net/bridge folder is only created in the >initial network namespace I think we can add one single sysctl to expose these as flags from net namespaces. Idea is to keep the existing (legacy) sysctl entries for init_net only, and add a new single new one that exposes these as flags (should be also available for consistency in init_net I'd suggest). Flags could be map in this way, eg. 0x1 call_iptables 0x2 call_ip6tables 0x4 call_arptables 0x8 filter_vlan_tagged ... Also documentation would be good to have for this. Would this idea fly for you? Thanks.