From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yang Xiao <YangX92@hotmail.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jananis37@gmail.com" <jananis37@gmail.com>,
"r.weclawski@gmail.com" <r.weclawski@gmail.com>,
"santhameena13@gmail.com" <santhameena13@gmail.com>
Subject: Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c
Date: Tue, 27 Nov 2018 11:49:28 +0300 [thread overview]
Message-ID: <20181127084928.GO3088@unbuntlaptop> (raw)
In-Reply-To: <HK0PR01MB2163FB565C3ADD4BCE1FE7D2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
On Tue, Nov 27, 2018 at 08:41:53AM +0000, Yang Xiao wrote:
> Okay. I can send a patch to revert ef9209b642f.
>
> But, can you make sure that the condition "(pstapriv->sta_aid[pstat->aid
> - 1] == NULL)" can satisfies in the for loop?
->max_num_sta is either set in _rtw_init_sta_priv() or rtw_set_beacon().
You can see that it's <= MAX_STA.
regards,
dan carpenter
prev parent reply other threads:[~2018-11-27 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <HK0PR01MB216364A68D785B7EBC8DD43EADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 7:57 ` gregkh
2018-11-27 8:15 ` Dan Carpenter
[not found] ` <HK0PR01MB2163A0287797ECA3CDA68AA2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 8:34 ` Dan Carpenter
[not found] ` <HK0PR01MB2163FB565C3ADD4BCE1FE7D2ADD00@HK0PR01MB2163.apcprd01.prod.exchangelabs.com>
2018-11-27 8:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127084928.GO3088@unbuntlaptop \
--to=dan.carpenter@oracle.com \
--cc=YangX92@hotmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jananis37@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=r.weclawski@gmail.com \
--cc=santhameena13@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®