From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF409C43441 for ; Tue, 27 Nov 2018 10:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A081A208E4 for ; Tue, 27 Nov 2018 10:33:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A081A208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730726AbeK0Vad (ORCPT ); Tue, 27 Nov 2018 16:30:33 -0500 Received: from mail.bootlin.com ([62.4.15.54]:35636 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726445AbeK0Vac (ORCPT ); Tue, 27 Nov 2018 16:30:32 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 56A31206A1; Tue, 27 Nov 2018 11:33:03 +0100 (CET) Received: from localhost (aaubervilliers-681-1-94-205.w90-88.abo.wanadoo.fr [90.88.35.205]) by mail.bootlin.com (Postfix) with ESMTPSA id 2E42D20D29; Tue, 27 Nov 2018 11:32:53 +0100 (CET) Date: Tue, 27 Nov 2018 11:32:53 +0100 From: Maxime Ripard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Hao Zhang , robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, mturquette@baylibre.com, sboyd@kernel.org, thierry.reding@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 1/6] Documentation: ARM: sunxi: pwm: add Allwinner sun8i. Message-ID: <20181127103253.ubbjjy2ji6sxc7xs@flea> References: <20181125161859.GA5277@arx-s1> <20181127075226.qo3mv3o6etqdjaop@flea> <20181127083523.pciie2gyaplrwiey@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t4dgavpmjejg77mf" Content-Disposition: inline In-Reply-To: <20181127083523.pciie2gyaplrwiey@pengutronix.de> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --t4dgavpmjejg77mf Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2018 at 09:35:23AM +0100, Uwe Kleine-K=F6nig wrote: > Hello, >=20 > On Tue, Nov 27, 2018 at 08:52:26AM +0100, Maxime Ripard wrote: > > On Mon, Nov 26, 2018 at 12:18:59AM +0800, Hao Zhang wrote: > > > + - clocks: From common clock binding, handle to the parent clock. > > > + - clock-names: Must contain the clock names described just above. > >=20 > > [...] > >=20 > > You seem to have used mux-0 and mux-1 for the clock names. I guess we > > don't have to use a name there, we can simply use the position to find > > out (as long as it's documented in the binding) >=20 > I also wondered if the driver relies on the fact that the second clock > is the faster running one. Is this sensible? Not really, I'm not sure we can make those expectations in the DT binding, especially since clock rate can change at runtime. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --t4dgavpmjejg77mf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCW/0dVQAKCRDj7w1vZxhR xWJdAQDW/2ZVKI8YZGRXlYR6/0v3Jouh2V9QpPDIL6Ae0KaXkQD+LAAS+KtX4+7x hJtiDCvE2+4leY4Ff+MyXhA8Q6itugY= =hYrT -----END PGP SIGNATURE----- --t4dgavpmjejg77mf--