From: Luming Yu <luming.yu@intel.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] reorder slow clock source read for clock source watchdog
Date: Tue, 27 Nov 2018 13:15:16 +0200 [thread overview]
Message-ID: <20181127111516.73733-1-luming.yu@intel.com> (raw)
the clock source watchdog (HPET) in skx is much slower
than the clock source TSC. The long latency in the first
call may trigger a false postive TSC unstable noise.
Let the fast one follows the slow one should fix it.
Signed-off-by: Luming Yu <luming.yu@intel.com>
Signed-off-by: Yongkai Wu <yongkaiwu@tencent.com>
---
kernel/time/clocksource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index ffe081623aec..8ea929e50ca6 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -225,8 +225,8 @@ static void clocksource_watchdog(struct timer_list *unused)
}
local_irq_disable();
- csnow = cs->read(cs);
wdnow = watchdog->read(watchdog);
+ csnow = cs->read(cs);
local_irq_enable();
/* Clocksource initialized ? */
--
2.14.4
reply other threads:[~2018-11-27 11:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127111516.73733-1-luming.yu@intel.com \
--to=luming.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®