From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E66C43441 for ; Tue, 27 Nov 2018 12:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3D4F208E4 for ; Tue, 27 Nov 2018 12:35:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3D4F208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zte.com.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729217AbeK0Xd3 (ORCPT ); Tue, 27 Nov 2018 18:33:29 -0500 Received: from mxhk.zte.com.cn ([63.217.80.70]:11974 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbeK0Xd3 (ORCPT ); Tue, 27 Nov 2018 18:33:29 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 066CBB2F2355EC6B8623; Tue, 27 Nov 2018 20:35:39 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id wARCZOPk078759; Tue, 27 Nov 2018 20:35:24 +0800 (GMT-8) (envelope-from wen.yang99@zte.com.cn) Received: from LIN-A6CB96A0603.zte.intra ([10.90.106.118]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2018112720354038-13299299 ; Tue, 27 Nov 2018 20:35:40 +0800 From: Wen Yang To: olivier.moysan@st.com, arnaud.pouliquen@st.com, broonie@kernel.org, tiwai@suse.com, mcoquelin.stm32@gmail.com Cc: linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn, Wen Yang , Liam Girdwood , Jaroslav Kysela , Alexandre Torgue , Julia Lawall , Wen Yang , linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH] Fix invalid use of sizeof in stm32_sai_add_mclk_provider() Date: Tue, 27 Nov 2018 20:35:20 +0800 Message-Id: <20181127123520.44940-1-wen.yang99@zte.com.cn> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2018-11-27 20:35:40, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2018-11-27 20:35:19 Content-Transfer-Encoding: quoted-printable X-MAIL: mse01.zte.com.cn wARCZOPk078759 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sizeof(mclk) is 4 or 8 as it is the size of a pointer, but we want to reserve space for the pointed data. This issue was detected by using the Coccinelle software. Signed-off-by: Wen Yang CC: Olivier Moysan CC: Arnaud Pouliquen CC: Liam Girdwood CC: Jaroslav Kysela CC: Takashi Iwai CC: Maxime Coquelin CC: Alexandre Torgue CC: Julia Lawall CC: Wen Yang CC: linux-stm32@st-md-mailman.stormreply.com CC: linux-kernel@vger.kernel.org --- sound/soc/stm/stm32=5Fsai=5Fsub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32=5Fsai=5Fsub.c b/sound/soc/stm/stm32=5Fsai= =5Fsub.c index ea05cc91aa05..211589b0b2ef 100644 --- a/sound/soc/stm/stm32=5Fsai=5Fsub.c +++ b/sound/soc/stm/stm32=5Fsai=5Fsub.c @@ -390,7 +390,7 @@ static int stm32=5Fsai=5Fadd=5Fmclk=5Fprovider(struct s= tm32=5Fsai=5Fsub=5Fdata *sai) char *mclk=5Fname, *p, *s =3D (char *)pname; int ret, i =3D 0; =20 - mclk =3D devm=5Fkzalloc(dev, sizeof(mclk), GFP=5FKERNEL); + mclk =3D devm=5Fkzalloc(dev, sizeof(*mclk), GFP=5FKERNEL); if (!mclk) return -ENOMEM; =20 --=20 2.19.1