From: Feng Tang <feng.tang@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <john.stultz@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] panic: Add options to print system info when panic happens
Date: Wed, 28 Nov 2018 11:41:00 +0800 [thread overview]
Message-ID: <20181128034100.tuiw6dm2gdb6wxim@shbuild888> (raw)
In-Reply-To: <20181127132318.203460a2@gandalf.local.home>
Hi Steven,
On Tue, Nov 27, 2018 at 01:23:18PM -0500, Steven Rostedt wrote:
> On Tue, 27 Nov 2018 15:15:20 +0800
> Feng Tang <feng.tang@intel.com> wrote:
>
> > Kernel panic issues are always painful to debug, partially
> > because it's not easy to get enough information of the
> > context when panic happens.
> >
> > And we have ramoops and kdump for that, while this commit
> > tries to provide a easier way to show the system info by adding
> > a cmdline parameter, referring some idea from sysrq handler.
> >
> > Signed-off-by: Feng Tang <feng.tang@intel.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: John Stultz <john.stultz@linaro.org>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > ---
> > Changelog:
> > v2:
> > - change text "dump/DUMP" to "print/PRINT" which
> > is more accurate, suggested by Andrew Morton
> > - add code to print ftrace buffer
> >
> > Documentation/admin-guide/kernel-parameters.txt | 8 +++++++
> > kernel/panic.c | 28 +++++++++++++++++++++++++
> > 2 files changed, 36 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index 19f4423..80c819a 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -3081,6 +3081,14 @@
> > timeout < 0: reboot immediately
> > Format: <timeout>
> >
> > + panic_print= Bitmask for printing system info when panic happens.
> > + User can chose combination of the following bits:
> > + bit 0: print all tasks info
> > + bit 1: print system memory info
> > + bit 2: print timer info
> > + bit 3: print locks info if CONFIG_LOCKDEP is on
>
> > + bit 4: print ftrace buffer
>
> Note, "ftrace_dump_on_oops" accomplishes the same thing.
>
> Should this be a sysctl setting as well?
Thanks for the suggestion and note. I will add sysctl part in next version.
- Feng
prev parent reply other threads:[~2018-11-28 3:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 7:15 Feng Tang
2018-11-27 17:20 ` Kees Cook
2018-11-27 18:23 ` Steven Rostedt
2018-11-28 3:41 ` Feng Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128034100.tuiw6dm2gdb6wxim@shbuild888 \
--to=feng.tang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®