From: Steven Rostedt <rostedt@goodmis.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: akpm@linux-foundation.org, dvyukov@google.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] kernel/kcov.c: mark funcs in __sanitizer_cov_trace_pc as notrace
Date: Wed, 28 Nov 2018 09:05:07 -0500 [thread overview]
Message-ID: <20181128090507.41791fe7@gandalf.local.home> (raw)
In-Reply-To: <20181128081239.18317-1-anders.roxell@linaro.org>
On Wed, 28 Nov 2018 09:12:39 +0100
Anders Roxell <anders.roxell@linaro.org> wrote:
> Since __sanitizer_cov_trace_pc is marked as notrace, function calls in
> __sanitizer_cov_trace_pc shouldn't be traced either. The function
> ftrace_graph_caller() gets called for each function that isn't marked
> 'notrace', like canonicalize_ip(). This is the call trace from a run:
>
> [ 139.644550] ftrace_graph_caller+0x1c/0x24
> [ 139.648352] canonicalize_ip+0x18/0x28
> [ 139.652313] __sanitizer_cov_trace_pc+0x14/0x58
> [ 139.656184] sched_clock+0x34/0x1e8
> [ 139.659759] trace_clock_local+0x40/0x88
> [ 139.663722] ftrace_push_return_trace+0x8c/0x1f0
> [ 139.667767] prepare_ftrace_return+0xa8/0x100
> [ 139.671709] ftrace_graph_caller+0x1c/0x24
>
> Rework so that the functions check_kcov_mode and canonicalize_ip that is
> callef from __sanitizer_cov_trace_pc also is marked as notrace.
>
> Co-developed-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signen-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
prev parent reply other threads:[~2018-11-28 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 8:12 Anders Roxell
2018-11-28 14:05 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128090507.41791fe7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®