From: Steven Rostedt <rostedt@goodmis.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Jonathan Corbet <corbet@lwn.net>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <john.stultz@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3 0/2] panic: Add options to dump system info on panic
Date: Wed, 28 Nov 2018 09:12:01 -0500 [thread overview]
Message-ID: <20181128091201.7dd80c92@gandalf.local.home> (raw)
In-Reply-To: <1543398842-19295-1-git-send-email-feng.tang@intel.com>
On Wed, 28 Nov 2018 17:54:00 +0800
Feng Tang <feng.tang@intel.com> wrote:
> Kernel panic issues are always painful to debug, partially
> because it's not easy to get enough information of the
> context when panic happens.
>
> And we have ramoops and kdump for that, while this commit
> tries to provide a easier way to show the system info by adding
> a cmdline parameter, referring some idea from sysrq handler.
>
> The patches have been used by us and did help on solving some nasty
> panic cases.
>
> Please help to review, thanks!
>
Looks fine to me.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Although, I still wonder if we should add a comment stating that bit 4
is the same as ftrace_dump_on_oops.
-- Steve
prev parent reply other threads:[~2018-11-28 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 9:54 Feng Tang
2018-11-28 9:54 ` [PATCH v3 1/2] panic: Add options to print system info when panic happens Feng Tang
2018-11-28 9:54 ` [PATCH v3 2/2] kernel/sysctl: Add panic_print into sysctl Feng Tang
2018-11-28 14:12 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128091201.7dd80c92@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=feng.tang@intel.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®