From: Gerd Hoffmann <kraxel@redhat.com>
To: David Airlie <airlied@redhat.com>, dri-devel@lists.freedesktop.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
David Airlie <airlied@linux.ie>,
virtualization@lists.linux-foundation.org (open list:DRM DRIVER
FOR QXL VIRTUAL GPU), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/6] drm/qxl: move qxl_primary_apply_cursor to correct place
Date: Wed, 28 Nov 2018 11:34:13 +0100 [thread overview]
Message-ID: <20181128103418.28023-2-kraxel@redhat.com> (raw)
In-Reply-To: <20181128103418.28023-1-kraxel@redhat.com>
The cursor must be set again after creating the primary surface.
Also drop the error message.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/qxl/qxl_display.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index ce0b9c40fc..58fb2c4308 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -533,7 +533,6 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
.x2 = plane->state->fb->width,
.y2 = plane->state->fb->height
};
- int ret;
bool same_shadow = false;
if (old_state->fb) {
@@ -554,16 +553,13 @@ static void qxl_primary_atomic_update(struct drm_plane *plane,
if (!same_shadow)
qxl_io_destroy_primary(qdev);
bo_old->is_primary = false;
-
- ret = qxl_primary_apply_cursor(plane);
- if (ret)
- DRM_ERROR(
- "could not set cursor after creating primary");
}
if (!bo->is_primary) {
- if (!same_shadow)
+ if (!same_shadow) {
qxl_io_create_primary(qdev, 0, bo);
+ qxl_primary_apply_cursor(plane);
+ }
bo->is_primary = true;
}
--
2.9.3
next parent reply other threads:[~2018-11-28 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181128103418.28023-1-kraxel@redhat.com>
2018-11-28 10:34 ` Gerd Hoffmann [this message]
2018-11-28 10:34 ` [PATCH 2/6] drm/qxl: drop unused offset parameter from qxl_io_create_primary() Gerd Hoffmann
2018-11-28 10:34 ` [PATCH 3/6] drm/qxl: track primary bo Gerd Hoffmann
2018-11-28 10:34 ` [PATCH 4/6] drm/qxl: use shadow bo directly Gerd Hoffmann
2018-11-28 10:34 ` [PATCH 5/6] drm/qxl: cover all crtcs in shadow bo Gerd Hoffmann
2018-11-28 10:34 ` [PATCH 6/6] drm/qxl: use qxl_num_crtc directly Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128103418.28023-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®