From: kbuild test robot <lkp@intel.com>
To: Florian Eckert <fe@dev.tdt.de>
Cc: kbuild-all@01.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, dvhart@infradead.org,
andy@infradead.org, Eckert.Florian@googlemail.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Florian Eckert <fe@dev.tdt.de>
Subject: Re: [PATCH v5 2/2] platform: Add reset button device for PC Engines APU boards
Date: Thu, 29 Nov 2018 01:06:55 +0800 [thread overview]
Message-ID: <201811290148.u0QRrvx0%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181127132508.5501-3-fe@dev.tdt.de>
[-- Attachment #1: Type: text/plain, Size: 3490 bytes --]
Hi Florian,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on gpio/for-next]
[also build test ERROR on v4.20-rc4 next-20181128]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Florian-Eckert/Add-device-driver-for-APU2-APU3-GPIOs/20181128-045043
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/gpio/gpio-apu.c:163:1: error: Expected ; at end of declaration
>> drivers/gpio/gpio-apu.c:163:1: error: got extern
In file included from drivers/gpio/gpio-apu.c:13:0:
include/linux/module.h:213:1: error: expected ',' or ';' before 'extern'
extern typeof(name) __mod_##type##__##name##_device_table \
^
drivers/gpio/gpio-apu.c:163:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
MODULE_DEVICE_TABLE(dmi, apu2_gpio_dmi_table);
^~~~~~~~~~~~~~~~~~~
vim +163 drivers/gpio/gpio-apu.c
4c30b3d4 Florian Eckert 2018-11-27 135
4c30b3d4 Florian Eckert 2018-11-27 136 static const struct dmi_system_id apu2_gpio_dmi_table[] __initconst = {
4c30b3d4 Florian Eckert 2018-11-27 137 /* PC Engines APU2 with "Legacy" bios < 4.0.8 */
4c30b3d4 Florian Eckert 2018-11-27 138 {
4c30b3d4 Florian Eckert 2018-11-27 139 .ident = "apu2",
4c30b3d4 Florian Eckert 2018-11-27 140 .matches = {
4c30b3d4 Florian Eckert 2018-11-27 141 DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
4c30b3d4 Florian Eckert 2018-11-27 142 DMI_MATCH(DMI_BOARD_NAME, "APU2")
4c30b3d4 Florian Eckert 2018-11-27 143 }
4c30b3d4 Florian Eckert 2018-11-27 144 },
4c30b3d4 Florian Eckert 2018-11-27 145 /* PC Engines APU2 with "Legacy" bios >= 4.0.8 */
4c30b3d4 Florian Eckert 2018-11-27 146 {
4c30b3d4 Florian Eckert 2018-11-27 147 .ident = "apu2",
4c30b3d4 Florian Eckert 2018-11-27 148 .matches = {
4c30b3d4 Florian Eckert 2018-11-27 149 DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
4c30b3d4 Florian Eckert 2018-11-27 150 DMI_MATCH(DMI_BOARD_NAME, "apu2")
4c30b3d4 Florian Eckert 2018-11-27 151 }
4c30b3d4 Florian Eckert 2018-11-27 152 },
4c30b3d4 Florian Eckert 2018-11-27 153 /* PC Engines APU2 with "Mainline" bios */
4c30b3d4 Florian Eckert 2018-11-27 154 {
4c30b3d4 Florian Eckert 2018-11-27 155 .ident = "apu2",
4c30b3d4 Florian Eckert 2018-11-27 156 .matches = {
4c30b3d4 Florian Eckert 2018-11-27 157 DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
4c30b3d4 Florian Eckert 2018-11-27 158 DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu2")
4c30b3d4 Florian Eckert 2018-11-27 159 }
4c30b3d4 Florian Eckert 2018-11-27 160 },
4c30b3d4 Florian Eckert 2018-11-27 161 {}
4c30b3d4 Florian Eckert 2018-11-27 162 }
4c30b3d4 Florian Eckert 2018-11-27 @163 MODULE_DEVICE_TABLE(dmi, apu2_gpio_dmi_table);
4c30b3d4 Florian Eckert 2018-11-27 164
:::::: The code at line 163 was first introduced by commit
:::::: 4c30b3d47204299cdb436562e2099c4a72427db7 gpio: Add driver for PC Engines APU boards
:::::: TO: Florian Eckert <fe@dev.tdt.de>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66638 bytes --]
next prev parent reply other threads:[~2018-11-28 17:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 13:25 [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs Florian Eckert
2018-11-27 13:25 ` [PATCH v5 1/2] gpio: Add driver for PC Engines APU boards Florian Eckert
2018-11-28 5:19 ` kbuild test robot
2018-11-28 12:00 ` Andy Shevchenko
2018-12-04 10:17 ` Florian Eckert
2018-11-27 13:25 ` [PATCH v5 2/2] platform: Add reset button device " Florian Eckert
2018-11-28 12:05 ` Andy Shevchenko
2018-11-28 17:06 ` kbuild test robot [this message]
2018-11-28 12:07 ` [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs Andy Shevchenko
2018-11-29 10:15 ` Florian Eckert
2018-11-29 13:44 ` Andy Shevchenko
2018-11-29 14:02 ` Florian Eckert
2018-11-29 15:24 ` Andy Shevchenko
2018-12-03 7:58 ` Florian Eckert
2018-12-03 15:43 ` Andy Shevchenko
2018-12-04 9:58 ` Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201811290148.u0QRrvx0%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=Eckert.Florian@googlemail.com \
--cc=andy@infradead.org \
--cc=bgolaszewski@baylibre.com \
--cc=dvhart@infradead.org \
--cc=fe@dev.tdt.de \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®