From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0986C43441 for ; Thu, 29 Nov 2018 10:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AACB2081C for ; Thu, 29 Nov 2018 10:28:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AACB2081C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728056AbeK2VdS (ORCPT ); Thu, 29 Nov 2018 16:33:18 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:60790 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726780AbeK2VdR (ORCPT ); Thu, 29 Nov 2018 16:33:17 -0500 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wATAOHmC016617; Thu, 29 Nov 2018 04:28:23 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail3.cirrus.com ([87.246.76.56]) by mx0a-001ae601.pphosted.com with ESMTP id 2p2724rx8j-1; Thu, 29 Nov 2018 04:28:22 -0600 Received: from EX17.ad.cirrus.com (ex17.ad.cirrus.com [172.20.9.81]) by mail3.cirrus.com (Postfix) with ESMTP id 46993611C8B3; Thu, 29 Nov 2018 04:31:13 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Thu, 29 Nov 2018 10:28:21 +0000 Received: from algalon.ad.cirrus.com (algalon.ad.cirrus.com [198.90.251.122]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id wATASLbZ028814; Thu, 29 Nov 2018 10:28:21 GMT From: Charles Keepax To: CC: , , Subject: [PATCH 0/2] Allow regulator nodes to hold their own init data Date: Thu, 29 Nov 2018 10:28:19 +0000 Message-ID: <20181129102821.18396-1-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=845 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811290091 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unfortunately due to a rather large testing oversight on my part the recently merged Lochnagar regulator binding does not actually work. The binding looks like this: lochnagar { compatible = "cirrus,lochnagar1"; ... lochnagar-micvdd: MICVDD { compatible = "cirrus,lochnagar2-micvdd"; SYSVDD-supply = <&wallvdd>; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; }; lochnagar-vddcore: VDDCORE { compatible = "cirrus,lochnagar2-vddcore"; SYSVDD-supply = <&wallvdd>; regulator-min-microvolt = <1200000>; regulator-max-microvolt = <1200000>; }; }; The trouble is that each regulator node individually binds in a driver and contains the init data. The regulator core appears to require the init data to be a sub-node of the node that bound in the regulator driver. As the above binding seems reasonable I opted to try and update the core to support the current binding, although as the rest of the Lochnagar driver isn't merged yet we could still update the binding if that comes out of the review as a preferred option. Apologies for missing such a glaring issue in my testing. Thanks, Charles Charles Keepax (2): regulator: Factor out location of init data OF node regulator: Allow regulator nodes to contain their own init data drivers/regulator/of_regulator.c | 72 ++++++++++++++++++++++++---------------- 1 file changed, 43 insertions(+), 29 deletions(-) -- 2.11.0