From: Mark Brown <broonie@kernel.org>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: olivier.moysan@st.com, arnaud.pouliquen@st.com, tiwai@suse.com,
mcoquelin.stm32@gmail.com, linux-kernel@vger.kernel.org,
zhong.weidong@zte.com.cn, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Alexandre Torgue <alexandre.torgue@st.com>,
Julia Lawall <julia.lawall@lip6.fr>,
Wen Yang <yellowriver2010@hotmail.com>,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] ASoC: stm32: sai: Fix unsigned comparison with less than zero
Date: Thu, 29 Nov 2018 11:55:45 +0000 [thread overview]
Message-ID: <20181129115545.GD10570@sirena.org.uk> (raw)
In-Reply-To: <20181129020611.8436-1-wen.yang99@zte.com.cn>
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
On Thu, Nov 29, 2018 at 10:06:11AM +0800, Wen Yang wrote:
> The return from the call to stm32_sai_get_clk_div can be a negative error
> code however this is being assigned to an unsigned variable 'div'
> hence the check is always false. Fix this by making 'div' an
> int.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-11-29 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 2:06 Wen Yang
2018-11-29 11:55 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129115545.GD10570@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=julia.lawall@lip6.fr \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@st.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wen.yang99@zte.com.cn \
--cc=yellowriver2010@hotmail.com \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®