From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB37EC43610 for ; Thu, 29 Nov 2018 18:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EE98213A2 for ; Thu, 29 Nov 2018 18:08:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EE98213A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727296AbeK3FO7 (ORCPT ); Fri, 30 Nov 2018 00:14:59 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:49360 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbeK3FO7 (ORCPT ); Fri, 30 Nov 2018 00:14:59 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1gSQk0-0006UN-DJ; Thu, 29 Nov 2018 18:08:44 +0000 From: Colin King To: Greg Kroah-Hartman , "Rafael J . Wysocki" Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] drivers: base: remove need for a temporary string for the node name Date: Thu, 29 Nov 2018 18:08:44 +0000 Message-Id: <20181129180844.31138-1-colin.king@canonical.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Currently the node name is being formatting into a temporary string node_name, however, kobject_init_and_add allows one to format up a node name, so use that instead. This removes the need for the node_name string and also cleans up the following warning: Fixes clang warning: warning: format string is not a string literal (potentially insecure) [-Wformat-security] Signed-off-by: Colin Ian King --- drivers/base/swnode.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 9c63ec8d8ab4..306bb93287af 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -553,7 +553,6 @@ fwnode_create_software_node(const struct property_entry *properties, { struct software_node *p = NULL; struct software_node *swnode; - char node_name[20]; int ret; if (parent) { @@ -576,8 +575,6 @@ fwnode_create_software_node(const struct property_entry *properties, } swnode->id = ret; - sprintf(node_name, "node%d", swnode->id); - swnode->kobj.kset = swnode_kset; swnode->fwnode.ops = &software_node_ops; @@ -590,7 +587,7 @@ fwnode_create_software_node(const struct property_entry *properties, list_add_tail(&swnode->entry, &p->children); ret = kobject_init_and_add(&swnode->kobj, &software_node_type, - p ? &p->kobj : NULL, node_name); + p ? &p->kobj : NULL, "node%d", swnode->id); if (ret) { kobject_put(&swnode->kobj); return ERR_PTR(ret); -- 2.19.1