From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646C1C04EB8 for ; Fri, 30 Nov 2018 10:58:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E99E2147D for ; Fri, 30 Nov 2018 10:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E99E2147D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbeK3WG6 (ORCPT ); Fri, 30 Nov 2018 17:06:58 -0500 Received: from mga02.intel.com ([134.134.136.20]:58443 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbeK3WG6 (ORCPT ); Fri, 30 Nov 2018 17:06:58 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2018 02:58:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,298,1539673200"; d="scan'208";a="254918942" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga004.jf.intel.com with ESMTP; 30 Nov 2018 02:58:01 -0800 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1gSgUh-0002T7-RU; Fri, 30 Nov 2018 12:57:59 +0200 Date: Fri, 30 Nov 2018 12:57:59 +0200 From: Andy Shevchenko To: Wolfram Sang Cc: Darren Hart , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Jonathan Cameron , Mika Westerberg , linux-i2c@vger.kernel.org, Hans de Goede , Heikki Krogerus , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper Message-ID: <20181130105759.GK10650@smile.fi.intel.com> References: <20181128114535.80223-1-andriy.shevchenko@linux.intel.com> <20181128114535.80223-10-andriy.shevchenko@linux.intel.com> <20181130095533.GC1079@kunai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130095533.GC1079@kunai> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 10:55:33AM +0100, Wolfram Sang wrote: > On Wed, Nov 28, 2018 at 01:45:29PM +0200, Andy Shevchenko wrote: > > Besides current two users one more is coming. Definitely makes sense to > > introduce a helper. > > > > No functional change intended. > > > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Hans de Goede > > --- > > drivers/i2c/i2c-core-acpi.c | 41 ++++++++++++++++++++++++++----------- > > include/linux/acpi.h | 11 ++++++++++ > > Any reason this is not in i2c.h? Yes. As I explained earlier to some people there are facts affecting this: - the function is operate on top of solely ACPI structures - there is already similar function for GPIO and it stays like that On top of this recently I've discovered, that i2c.h has separate #ifdef for I2C and ACPI which theoretically might produce a linker error in some cases. -- With Best Regards, Andy Shevchenko