From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B8B7C64EB4 for ; Fri, 30 Nov 2018 12:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48A3C20863 for ; Fri, 30 Nov 2018 12:18:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48A3C20863 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbeK3X1E (ORCPT ); Fri, 30 Nov 2018 18:27:04 -0500 Received: from mga12.intel.com ([192.55.52.136]:2204 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726512AbeK3X1E (ORCPT ); Fri, 30 Nov 2018 18:27:04 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2018 04:17:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,298,1539673200"; d="scan'208";a="99405396" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga007.fm.intel.com with ESMTP; 30 Nov 2018 04:17:55 -0800 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1gShk2-0002v5-Dg; Fri, 30 Nov 2018 14:17:54 +0200 Date: Fri, 30 Nov 2018 14:17:54 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: Wolfram Sang , Darren Hart , platform-driver-x86@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, Jonathan Cameron , linux-i2c@vger.kernel.org, Hans de Goede , Heikki Krogerus , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 09/15] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper Message-ID: <20181130121754.GO10650@smile.fi.intel.com> References: <20181128114535.80223-1-andriy.shevchenko@linux.intel.com> <20181128114535.80223-10-andriy.shevchenko@linux.intel.com> <20181130095533.GC1079@kunai> <20181130105759.GK10650@smile.fi.intel.com> <20181130110652.ckj75wrxxaez2sq2@ninjato> <20181130114543.GM10650@smile.fi.intel.com> <20181130114950.av6pnedcqu27jyjc@ninjato> <20181130121231.GO3078@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181130121231.GO3078@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 02:12:31PM +0200, Mika Westerberg wrote: > On Fri, Nov 30, 2018 at 12:49:50PM +0100, Wolfram Sang wrote: > > > > > > Is this something we have to live with or which can be cleaned up > > > > somewhen? > > > > > > My opinion that we might need something like > > > drivers/acpi/acpi_i2c_lib.c > > > drivers/acpi/acpi_gpio_lib.c > > > etc. > > > > > > > Collect all of them in drivers/acpi/acpi_libs.c? > > > > > But better to ask Rafael and Mika what they think about this. > > IMHO all the bus specific ACPI things should go under those buses (so > the opposite what is proposed here) but I also don't think any of this > is show stopper for the patch series under discussion ;-) Thank you guys for your input, let me fix this later, out of this series. -- With Best Regards, Andy Shevchenko