From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9F3C04EB9 for ; Sat, 1 Dec 2018 17:05:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15D3B2082F for ; Sat, 1 Dec 2018 17:05:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15D3B2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbeLBESE (ORCPT ); Sat, 1 Dec 2018 23:18:04 -0500 Received: from verein.lst.de ([213.95.11.211]:56798 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726826AbeLBESE (ORCPT ); Sat, 1 Dec 2018 23:18:04 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 5A0AF6732A; Sat, 1 Dec 2018 18:05:06 +0100 (CET) Date: Sat, 1 Dec 2018 18:05:06 +0100 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, Catalin Marinas , Will Deacon , Guo Ren , Laura Abbott , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] dma-remap: support DMA_ATTR_NO_KERNEL_MAPPING Message-ID: <20181201170506.GE20912@lst.de> References: <20181105121931.13481-1-hch@lst.de> <20181105121931.13481-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 07:05:40PM +0000, Robin Murphy wrote: > On 05/11/2018 12:19, Christoph Hellwig wrote: >> Do not waste vmalloc space on allocations that do not require a mapping >> into the kernel address space. >> >> Signed-off-by: Christoph Hellwig >> --- >> kernel/dma/remap.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c >> index 8f1fca34b894..10a545126b0b 100644 >> --- a/kernel/dma/remap.c >> +++ b/kernel/dma/remap.c >> @@ -200,7 +200,8 @@ void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle, >> size = PAGE_ALIGN(size); >> - if (!gfpflags_allow_blocking(flags)) { >> + if (!gfpflags_allow_blocking(flags) && >> + !(attrs & DMA_ATTR_NO_KERNEL_MAPPING)) { >> ret = dma_alloc_from_pool(size, &page, flags); >> if (!ret) >> return NULL; >> @@ -215,6 +216,9 @@ void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle, >> /* remove any dirty cache lines on the kernel alias */ >> arch_dma_prep_coherent(page, size); >> + if (attrs & DMA_ATTR_NO_KERNEL_MAPPING) >> + return page; /* opaqueue cookie */ > > Best to preempt the inevitable patch fixing that typo in 3 months' time. > Otherwise, Thanks, fixed.