Re: [PATCH v3 0/7] zram idle page writeback

[Joey Pabalinas <joeypabalinas@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2008 bytes --]

On Tue, Nov 27, 2018 at 02:54:22PM +0900, Minchan Kim wrote:
> Inherently, swap device has many idle pages which are rare touched since
> it was allocated. It is never problem if we use storage device as swap.
> However, it's just waste for zram-swap.
> 
> This patchset supports zram idle page writeback feature.

Revisions look good to me. Will also try to give it some testing this
week.

Reviewed-by: Joey Pabalinas <joeypabalinas@gmail.com>

> * Admin can define what is idle page "no access since X time ago"
> * Admin can define when zram should writeback them
> * Admin can define when zram should stop writeback to prevent wearout
> 
> Detail is on each patch's description.
> 
> Below first two patches are -stable material so it could go first
> separately with others in this series.
> 
>   zram: fix lockdep warning of free block handling
>   zram: fix double free backing device
> 
> * from v2
>   - use strscpy instead of strlcpy - Joey Pabalinas
>   - remove irqlock for bitmap op - akpm
>   - don't use page as stat unit - akpm
> 
> * from v1
>   - add fix dobule free backing device - minchan
>   - change writeback/idle interface - minchan 
>   - remove direct incompressible page writeback - sergey
> 
> Minchan Kim (7):
>   zram: fix lockdep warning of free block handling
>   zram: fix double free backing device
>   zram: refactoring flags and writeback stuff
>   zram: introduce ZRAM_IDLE flag
>   zram: support idle/huge page writeback
>   zram: add bd_stat statistics
>   zram: writeback throttle
> 
>  Documentation/ABI/testing/sysfs-block-zram |  32 ++
>  Documentation/blockdev/zram.txt            |  51 ++-
>  drivers/block/zram/Kconfig                 |   5 +-
>  drivers/block/zram/zram_drv.c              | 501 +++++++++++++++------
>  drivers/block/zram/zram_drv.h              |  19 +-
>  5 files changed, 446 insertions(+), 162 deletions(-)
> 
> -- 
> 2.20.0.rc0.387.gc7a69e6b6c-goog
> 

-- 
Cheers,
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]