On Fri 2018-11-30 20:51:54, Yangtao Li wrote: > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such > a macro,so remove define_genpd_open_function and define_genpd_debugfs_fops. > Also use DEFINE_SHOW_ATTRIBUTE to simplify somecode. "and there", ", so". > Signed-off-by: Yangtao Li Otherwise looks good. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html