From: Nishanth Menon <nm@ti.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] mailbox: ti-msgmgr: Off by one in ti_msgmgr_of_xlate()
Date: Mon, 3 Dec 2018 09:51:50 -0600 [thread overview]
Message-ID: <20181203155150.ohsc42cbbkkgrvsm@kahuna> (raw)
In-Reply-To: <20181203145011.7s3udfz4cug3ph3k@kili.mountain>
On 17:50-20181203, Dan Carpenter wrote:
> The > comparison should be >= or we access one element beyond the end
> of the array.
>
> (The inst->qinsts[] array is allocated in the ti_msgmgr_probe() function
> and it has ->num_valid_queues elements.)
>
> Fixes: a2b79838b891 ("mailbox: ti-msgmgr: Add support for Secure Proxy")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/mailbox/ti-msgmgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
> index 713d701b6568..6f6addd51d14 100644
> --- a/drivers/mailbox/ti-msgmgr.c
> +++ b/drivers/mailbox/ti-msgmgr.c
> @@ -547,7 +547,7 @@ static struct mbox_chan *ti_msgmgr_of_xlate(struct mbox_controller *mbox,
> }
>
> if (d->is_sproxy) {
> - if (req_pid > d->num_valid_queues)
> + if (req_pid >= d->num_valid_queues)
> goto err;
> qinst = &inst->qinsts[req_pid];
> return qinst->chan;
> --
> 2.11.0
>
OOpps.. Thanks for catching it.
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2018-12-03 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 14:50 Dan Carpenter
2018-12-03 15:51 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203155150.ohsc42cbbkkgrvsm@kahuna \
--to=nm@ti.com \
--cc=dan.carpenter@oracle.com \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®