mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: mingo@redhat.com, Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tracing: add cond_resched to ftrace_replace_code()
Date: Tue, 4 Dec 2018 14:29:18 -0500	[thread overview]
Message-ID: <20181204142918.12c087b4@vmware.local.home> (raw)
In-Reply-To: <CADYN=9LNunVkSTzg1fri7Mu7mbu8gFPpgnFfCRQk4T61JXt1_A@mail.gmail.com>

On Tue, 4 Dec 2018 20:25:31 +0100
Anders Roxell <anders.roxell@linaro.org> wrote:

> On Tue, 4 Dec 2018 at 20:21, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Tue, 4 Dec 2018 14:19:08 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >  
> > > > @@ -2435,6 +2438,13 @@ void __weak ftrace_replace_code(int enable)
> > > >                     /* Stop processing */
> > > >                     return;
> > > >             }
> > > > +           /*
> > > > +            * Some archs calls this function with interrupts or preemption
> > > > +            * disabled. Howeve, other archs don't and this can cause a  
> >
> > typo "However". But could you write it this way:
> >
> >         "However, for other archs that can preempt, this can cause an
> >         tremendous unneeded latency."
> >  
> 
> I'll fix this and move it up (where I added it in the first place but
> moved it) =)
>

I also noticed a grammar issue:

	"Some archs call this function .."

-- Steve

  reply	other threads:[~2018-12-04 19:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 19:12 Anders Roxell
2018-12-04 19:19 ` Steven Rostedt
2018-12-04 19:21   ` Steven Rostedt
2018-12-04 19:25     ` Anders Roxell
2018-12-04 19:29       ` Steven Rostedt [this message]
2018-12-04 19:34         ` Anders Roxell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204142918.12c087b4@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®