From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH v2 4/4] x86/vdso: Rename "required_syms" to "requested_syms"
Date: Tue, 4 Dec 2018 13:26:00 -0800 [thread overview]
Message-ID: <20181204212600.28090-5-sean.j.christopherson@intel.com> (raw)
In-Reply-To: <20181204212600.28090-1-sean.j.christopherson@intel.com>
The "required" moniker implies that vdso2c will fail if one of the
defined symbols is not found, which is simply not true, e.g.
VDSO32_NOTE_MASK is quite obviously 32-bit only and not required
for the 64-bit image.
Cc: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
arch/x86/entry/vdso/vdso2c.c | 4 ++--
arch/x86/entry/vdso/vdso2c.h | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/x86/entry/vdso/vdso2c.c b/arch/x86/entry/vdso/vdso2c.c
index a175cd2016c9..b2acdaffc66d 100644
--- a/arch/x86/entry/vdso/vdso2c.c
+++ b/arch/x86/entry/vdso/vdso2c.c
@@ -85,7 +85,7 @@ const int special_pages[] = {
sym_hvclock_page,
};
-const char *required_syms[] = {
+const char *requested_syms[] = {
[sym_vvar_start] = "vvar_start",
[sym_vvar_page] = "vvar_page",
[sym_hpet_page] = "hpet_page",
@@ -139,7 +139,7 @@ extern void bad_put_le(void);
PLE(x, val, 64, PLE(x, val, 32, PLE(x, val, 16, LAST_PLE(x, val))))
-#define NSYMS ARRAY_SIZE(required_syms)
+#define NSYMS ARRAY_SIZE(requested_syms)
#define BITSFUNC3(name, bits, suffix) name##bits##suffix
#define BITSFUNC2(name, bits, suffix) BITSFUNC3(name, bits, suffix)
diff --git a/arch/x86/entry/vdso/vdso2c.h b/arch/x86/entry/vdso/vdso2c.h
index 14003d311298..6c5a290ce468 100644
--- a/arch/x86/entry/vdso/vdso2c.h
+++ b/arch/x86/entry/vdso/vdso2c.h
@@ -97,10 +97,10 @@ static void BITSFUNC(go)(void *raw_addr, size_t raw_len,
GET_LE(&sym->st_name);
for (k = 0; k < NSYMS; k++) {
- if (!strcmp(name, required_syms[k])) {
+ if (!strcmp(name, requested_syms[k])) {
if (syms[k]) {
fail("duplicate symbol %s\n",
- required_syms[k]);
+ requested_syms[k]);
}
/*
@@ -123,12 +123,12 @@ static void BITSFUNC(go)(void *raw_addr, size_t raw_len,
if (symval % 4096)
fail("%s must be a multiple of 4096\n",
- required_syms[i]);
+ requested_syms[i]);
if (symval + 4096 < syms[sym_vvar_start])
- fail("%s underruns vvar_start\n", required_syms[i]);
+ fail("%s underruns vvar_start\n", requested_syms[i]);
if (symval + 4096 > 0)
fail("%s is on the wrong side of the vdso text\n",
- required_syms[i]);
+ requested_syms[i]);
}
if (syms[sym_vvar_start] % 4096)
fail("vvar_begin must be a multiple of 4096\n");
@@ -168,7 +168,7 @@ static void BITSFUNC(go)(void *raw_addr, size_t raw_len,
for (i = 0; i < NSYMS; i++) {
if (syms[i])
fprintf(outfile, "\t.sym_%s = %" PRIi64 ",\n",
- required_syms[i], (int64_t)syms[i]);
+ requested_syms[i], (int64_t)syms[i]);
}
fprintf(outfile, "};\n");
}
--
2.19.2
prev parent reply other threads:[~2018-12-04 21:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 21:25 [PATCH v2 0/4] x86/vdso: Remove remnants of the fake section table Sean Christopherson
2018-12-04 21:25 ` [PATCH v2 1/4] x86/vdso: Remove obsolete "fake section table" reservation Sean Christopherson
2018-12-04 22:48 ` Andy Lutomirski
2018-12-05 18:03 ` [tip:x86/asm] " tip-bot for Sean Christopherson
2018-12-04 21:25 ` [PATCH v2 2/4] x86/vdso: Remove a stale/misleading comment from the linker script Sean Christopherson
2018-12-04 22:49 ` Andy Lutomirski
2018-12-05 18:04 ` [tip:x86/asm] " tip-bot for Sean Christopherson
2018-12-04 21:25 ` [PATCH v2 3/4] x86/vdso: Remove struct vdso_sym and its associated export option Sean Christopherson
2018-12-04 21:26 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204212600.28090-5-sean.j.christopherson@intel.com \
--to=sean.j.christopherson@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®