From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kyle Williams <kdgwill@chromium.org>
Cc: "Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Rajat Jain" <rajatja@chromium.org>,
"Harry Pan" <harry.pan@intel.com>,
"Julius Werner" <jwerner@chromium.org>,
"Daniel Drake" <drake@endlessm.com>,
"Maxence Duprès" <xpros64@hotmail.fr>,
"Dmitry Fleytman Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Danilo Krummrich" <danilokrummrich@dk-develop.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Rally Camera
Date: Wed, 5 Dec 2018 10:35:07 +0100 [thread overview]
Message-ID: <20181205093507.GC1817@kroah.com> (raw)
In-Reply-To: <CAAd214VGLYUSE10AEfk+ujjnXRDr9-HxhtucoLKLVR35vzH3Rw@mail.gmail.com>
On Thu, Nov 29, 2018 at 07:59:09AM -0500, Kyle Williams wrote:
> Description: Some USB device / host controller combinations seem to have
> problems with Link Power management. In particular it is described that
> the combination of a Logitech Rally and Atrus device causes
> 'not enough bandwidth for new device state'error
>
> This patch creates quirk entries for the Logitech Rally Camera
> indicating LPM should remain disabled for the device.
>
> Signed-off-by: Kyle Williams <kdgwill@chromium.org>
> Reviewed-on: https://chromium-review.googlesource.com/1297535
> Commit-Ready: Kyle Williams <kdgwill@chromium.org>
> Tested-by: Kyle Williams <kdgwill@chromium.org>
> Reviewed-by: Julius Werner <jwerner@chromium.org>
> ---
> drivers/usb/core/quirks.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 2deac3a55957..49c44d89a394 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -224,6 +224,11 @@ static const struct usb_device_id usb_quirk_list[] = {
> /* Logitech Logitech Screen Share */
> { USB_DEVICE(0x046d, 0x086c), .driver_info = USB_QUIRK_NO_LPM },
>
> + /* Logitech Rally Camera */
> + { USB_DEVICE(0x046d, 0x0881), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x046d, 0x0888), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x046d, 0x0889), .driver_info = USB_QUIRK_NO_LPM },
> +
> /* Logitech Quickcam Fusion */
> { USB_DEVICE(0x046d, 0x08c1), .driver_info = USB_QUIRK_RESET_RESUME },
>
This patch had all tabs stripped out of it, and was sent in html :(
parent reply other threads:[~2018-12-05 9:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAAd214VGLYUSE10AEfk+ujjnXRDr9-HxhtucoLKLVR35vzH3Rw@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205093507.GC1817@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=danilokrummrich@dk-develop.de \
--cc=dmitry.fleytman@gmail.com \
--cc=drake@endlessm.com \
--cc=harry.pan@intel.com \
--cc=jwerner@chromium.org \
--cc=kai.heng.feng@canonical.com \
--cc=kdgwill@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rajatja@chromium.org \
--cc=xpros64@hotmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®