From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63F2C04EB9 for ; Wed, 5 Dec 2018 13:20:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE13E2084C for ; Wed, 5 Dec 2018 13:20:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE13E2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbeLENUC (ORCPT ); Wed, 5 Dec 2018 08:20:02 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:50329 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726918AbeLENUC (ORCPT ); Wed, 5 Dec 2018 08:20:02 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gUX5s-000849-LQ; Wed, 05 Dec 2018 14:20:00 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1gUX5s-0002PM-7j; Wed, 05 Dec 2018 14:20:00 +0100 Date: Wed, 5 Dec 2018 14:20:00 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Linus Walleij Cc: Bartosz Golaszewski , Thomas Gleixner , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski Subject: Re: [PATCH 1/2] irq/irq_sim: provide irq_sim_fire_edge() Message-ID: <20181205132000.f7n2stv2pxldzcxu@pengutronix.de> References: <20181125211854.idnqxz4pco3r7ydr@pengutronix.de> <20181202215613.jcfrxwl4taiqgsql@pengutronix.de> <20181203104923.gcb2bcsaoczjcjhk@pengutronix.de> <20181203110654.53o3prw3qu3u2uyf@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 05, 2018 at 01:19:54PM +0100, Linus Walleij wrote: > On Mon, Dec 3, 2018 at 12:06 PM Uwe Kleine-König > wrote: > > On Mon, Dec 03, 2018 at 11:57:26AM +0100, Bartosz Golaszewski wrote: > > > > It used to live in the gpio-mockup driver and I generalized it > > > precisely because there was another driver - iio evgen - which was > > > doing basically the same thing. While I don't know if there'll be more > > > users (I'd guess it would be useful for testing purposes of other > > > subsystems) having the same functionality implemented once is better > > > than twice. > > > > The iio testing driver only needs the trigger and relies on an irq that > > then calls the registerd handler. The iio driver doesn't need to tune > > the edge sensitivity though and if your mockup driver just only calls > > the fire routine if the configured sensitivity justifies that, > > everything should work as expected. > > Simulating edges in the generic IRQ simulator codes seems > generally useful to me, even if there is just one user now. I cannot imagine another potential user. Which kind of driver could use that that is not a gpio simulator? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |