From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CCE2C04EB9 for ; Wed, 5 Dec 2018 16:35:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56AEC20850 for ; Wed, 5 Dec 2018 16:35:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56AEC20850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727861AbeLEQfY (ORCPT ); Wed, 5 Dec 2018 11:35:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:44754 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727177AbeLEQfY (ORCPT ); Wed, 5 Dec 2018 11:35:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 90B8BAE66; Wed, 5 Dec 2018 16:35:21 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D5D271E0DBB; Wed, 5 Dec 2018 17:35:20 +0100 (CET) Date: Wed, 5 Dec 2018 17:35:20 +0100 From: Jan Kara To: jglisse@redhat.com Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Matthew Wilcox , Ross Zwisler , Jan Kara , Dan Williams , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Michal Hocko , Christian Koenig , Felix Kuehling , Ralph Campbell , John Hubbard , kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/3] mm/mmu_notifier: use structure for invalidate_range_start/end callback Message-ID: <20181205163520.GG30615@quack2.suse.cz> References: <20181205053628.3210-1-jglisse@redhat.com> <20181205053628.3210-2-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181205053628.3210-2-jglisse@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 05-12-18 00:36:26, jglisse@redhat.com wrote: > diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c > index 5119ff846769..5f6665ae3ee2 100644 > --- a/mm/mmu_notifier.c > +++ b/mm/mmu_notifier.c > @@ -178,14 +178,20 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm, > unsigned long start, unsigned long end, > bool blockable) > { > + struct mmu_notifier_range _range, *range = &_range; Why these games with two variables? > struct mmu_notifier *mn; > int ret = 0; > int id; > > + range->blockable = blockable; > + range->start = start; > + range->end = end; > + range->mm = mm; > + Use your init function for this? > id = srcu_read_lock(&srcu); > hlist_for_each_entry_rcu(mn, &mm->mmu_notifier_mm->list, hlist) { > if (mn->ops->invalidate_range_start) { > - int _ret = mn->ops->invalidate_range_start(mn, mm, start, end, blockable); > + int _ret = mn->ops->invalidate_range_start(mn, range); > if (_ret) { > pr_info("%pS callback failed with %d in %sblockable context.\n", > mn->ops->invalidate_range_start, _ret, > @@ -205,9 +211,20 @@ void __mmu_notifier_invalidate_range_end(struct mm_struct *mm, > unsigned long end, > bool only_end) > { > + struct mmu_notifier_range _range, *range = &_range; > struct mmu_notifier *mn; > int id; > > + /* > + * The end call back will never be call if the start refused to go > + * through because of blockable was false so here assume that we > + * can block. > + */ > + range->blockable = true; > + range->start = start; > + range->end = end; > + range->mm = mm; > + The same as above. Otherwise the patch looks good to me. Honza -- Jan Kara SUSE Labs, CR