From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0270C04EB8 for ; Thu, 6 Dec 2018 12:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 629D220892 for ; Thu, 6 Dec 2018 12:37:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 629D220892 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zte.com.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729617AbeLFMhz (ORCPT ); Thu, 6 Dec 2018 07:37:55 -0500 Received: from mxhk.zte.com.cn ([63.217.80.70]:46190 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728144AbeLFMhz (ORCPT ); Thu, 6 Dec 2018 07:37:55 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 10C8A4DE0564BC2ED0BA; Thu, 6 Dec 2018 20:37:53 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id wB6CbeWD063195; Thu, 6 Dec 2018 20:37:41 +0800 (GMT-8) (envelope-from wen.yang99@zte.com.cn) Received: from LIN-A6CB96A0603.zte.intra ([10.90.106.118]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2018120620381314-15145753 ; Thu, 6 Dec 2018 20:38:13 +0800 From: Wen Yang To: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani Cc: MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn, Wen Yang Subject: [PATCH] scsi: message: fusion: Use kmemdup instead of duplicating its function Date: Thu, 6 Dec 2018 20:37:33 +0800 Message-Id: <20181206123733.59427-1-wen.yang99@zte.com.cn> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2018-12-06 20:38:13, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2018-12-06 20:37:29 Content-Transfer-Encoding: quoted-printable X-MAIL: mse01.zte.com.cn wB6CbeWD063195 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kmemdup has implemented the function that kmalloc() + memcpy(). We prefer to kmemdup rather than code opened implementation. This issue was detected with the help of coccinelle. Signed-off-by: Wen Yang CC: Sathya Prakash CC: Chaitra P B CC: Suganath Prabu Subramani CC: MPT-FusionLinux.pdl@broadcom.com CC: linux-scsi@vger.kernel.org CC: linux-kernel@vger.kernel.org --- drivers/message/fusion/mptbase.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptb= ase.c index ba551d8dfba4..f8ec116cb9a4 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -6001,13 +6001,12 @@ mpt=5FfindImVolumes(MPT=5FADAPTER *ioc) if (mpt=5Fconfig(ioc, &cfg) !=3D 0) goto out; =20 - mem =3D kmalloc(iocpage2sz, GFP=5FKERNEL); + mem =3D kmemdup((u8 *)pIoc2, iocpage2sz, GFP=5FKERNEL); if (!mem) { rc =3D -ENOMEM; goto out; } =20 - memcpy(mem, (u8 *)pIoc2, iocpage2sz); ioc->raid=5Fdata.pIocPg2 =3D (IOCPage2=5Ft *) mem; =20 mpt=5Fread=5Fioc=5Fpg=5F3(ioc); --=20 2.19.1