From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9E7C07E85 for ; Fri, 7 Dec 2018 20:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0808C2146D for ; Fri, 7 Dec 2018 20:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0808C2146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726115AbeLGUYf (ORCPT ); Fri, 7 Dec 2018 15:24:35 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44550 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbeLGUYf (ORCPT ); Fri, 7 Dec 2018 15:24:35 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id DE263C34; Fri, 7 Dec 2018 20:24:34 +0000 (UTC) Date: Fri, 7 Dec 2018 12:24:34 -0800 From: Andrew Morton To: Qian Cai Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkstack.pl: fix for aarch64 Message-Id: <20181207122434.efb1941a3ded73267496c784@linux-foundation.org> In-Reply-To: <20181207195843.38528-1-cai@lca.pw> References: <20181207195843.38528-1-cai@lca.pw> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Dec 2018 14:58:43 -0500 Qian Cai wrote: > There is actually a space after "sp," like this, > > ffff2000080813c8: a9bb7bfd stp x29, x30, [sp, #-80]! > Confused. Why does this matter? Why is the patched version superior?