From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF074C07E85 for ; Mon, 10 Dec 2018 00:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BECC52064D for ; Mon, 10 Dec 2018 00:28:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BECC52064D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbeLJA2H (ORCPT ); Sun, 9 Dec 2018 19:28:07 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:53344 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbeLJA2G (ORCPT ); Sun, 9 Dec 2018 19:28:06 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0011F144C6663; Sun, 9 Dec 2018 16:28:05 -0800 (PST) Date: Sun, 09 Dec 2018 16:28:05 -0800 (PST) Message-Id: <20181209.162805.1102172618676272423.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com Subject: Re: linux-next: Signed-off-by missing for commits in the net-next tree From: David Miller In-Reply-To: <011f5be3-4bc1-2e64-0ddf-b43b8dbc4dcd@gmail.com> References: <20181210080045.0e67ad79@canb.auug.org.au> <20181209211139.GB21186@lunn.ch> <011f5be3-4bc1-2e64-0ddf-b43b8dbc4dcd@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 09 Dec 2018 16:28:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit Date: Sun, 9 Dec 2018 22:33:10 +0100 > On 09.12.2018 22:11, Andrew Lunn wrote: >> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: >>> Hi all, >>> >>> Commits >>> >>> dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data") >>> 04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask") >>> >>> are missing a Signed-off-by from their author. >> >> Hi David. >> >> Any idea what happened here? The version in my git repo has SOB. >> >> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB. >> > Instead of > v2 > -- > int -> u32 in platform data structure > > Signed-off-by: Andrew Lunn > > shouldn't it be > > Signed-off-by: Andrew Lunn > --- > v2 > - int -> u32 in platform data structure No, I want the changelog to actually appear in the commit message. I'm kinda tired of saying this. Keep changelog information in the commit message, everyone. The problem here is the '--' delimiter, Andrew should have either used nothing or something else.