From: YueHaibing <yuehaibing@huawei.com>
To: <davem@davemloft.net>, <h.morris@cascoda.com>,
<alex.aring@gmail.com>, <stefan@datenfreihafen.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-wpan@vger.kernel.org>, YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH net-next] ieee802154: ca8210: remove a dead branch
Date: Mon, 10 Dec 2018 19:34:43 +0800 [thread overview]
Message-ID: <20181210113443.22796-1-yuehaibing@huawei.com> (raw)
Fix follwing gcc warning:
drivers/net/ieee802154/ca8210.c:730:10: warning:
comparison is always false due to limited range of data type [-Wtype-limits]
the variable 'len' is of type u8 and cannot greater than
CA8210_SPI_BUF_SIZE , which is 256.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ieee802154/ca8210.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 0ff5a40..0fe204f 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -727,14 +727,6 @@ static void ca8210_rx_done(struct cas_control *cas_ctl)
buf = cas_ctl->tx_in_buf;
len = buf[1] + 2;
- if (len > CA8210_SPI_BUF_SIZE) {
- dev_crit(
- &priv->spi->dev,
- "Received packet len (%d) erroneously long\n",
- len
- );
- goto finish;
- }
if (buf[0] & SPI_SYN) {
if (priv->sync_command_response) {
--
2.7.0
next reply other threads:[~2018-12-10 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 11:34 YueHaibing [this message]
2018-12-10 20:04 ` David Miller
2018-12-11 1:51 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210113443.22796-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=h.morris@cascoda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®