From: Steven Rostedt <rostedt@goodmis.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@suse.de>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Petr Mladek <pmladek@suse.com>, Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Sasha Levin <sashal@kernel.org>,
stable@kernel.org
Subject: Re: [PATCH v4] panic: Avoid the extra noise dmesg
Date: Mon, 10 Dec 2018 13:17:29 -0500 [thread overview]
Message-ID: <20181210131729.04b8e0d3@gandalf.local.home> (raw)
In-Reply-To: <1544176279-77828-1-git-send-email-feng.tang@intel.com>
On Fri, 7 Dec 2018 17:51:19 +0800
Feng Tang <feng.tang@intel.com> wrote:
> When kernel panic happens, it will first print the panic call stack,
> then the ending msg like:
>
> [ 35.743249] ---[ end Kernel panic - not syncing: Fatal exception
> [ 35.749975] ------------[ cut here ]------------
>
> The above message are very useful for debugging.
>
> But if system is configured to not reboot on panic, say the "panic_timeout"
> parameter equals 0, it will likely print out many noisy message like
> WARN() call stack for each and every CPU except the panic one, messages
> like below:
> Keeping the interrupt disabled will avoid the noisy message.
>
> When code runs to this point, it means user has chosed to not reboot, or
> do any special handling by using the panic notifier method, the only reason
> to enable the interrupt may be sysrq migic key and panic_blink function
> (though may not work even with irq enabled).
>
> So make the irq disabled by default and add a cmdline parameter
> "panic_keep_irq_on" to turn it on when needed.
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2018-12-10 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 9:51 Feng Tang
2018-12-10 18:17 ` Steven Rostedt [this message]
2018-12-10 18:49 ` Kees Cook
2018-12-11 8:32 ` Petr Mladek
2019-02-15 5:56 ` Feng Tang
2019-02-20 13:43 ` Petr Mladek
2019-02-21 2:52 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210131729.04b8e0d3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=feng.tang@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®