From: David Miller <davem@davemloft.net>
To: amhetre@nvidia.com
Cc: herbert@gondor.apana.org.au, axboe@kernel.dk,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
linux-crypto@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org, vdumpa@nvidia.com,
mmaddireddy@nvidia.com, Snikam@nvidia.com,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.
Date: Tue, 11 Dec 2018 22:29:50 -0800 (PST) [thread overview]
Message-ID: <20181211.222950.1995970751331458343.davem@davemloft.net> (raw)
In-Reply-To: <1544595853-18492-1-git-send-email-amhetre@nvidia.com>
From: Ashish Mhetre <amhetre@nvidia.com>
Date: Wed, 12 Dec 2018 11:54:13 +0530
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 68e91ef..0a07a29 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -587,7 +587,7 @@ enum {
>
> struct nvme_sgl_desc {
> __le64 addr;
> - __le32 length;
> + __le64 length;
> __u8 rsvd[3];
> __u8 type;
> };
Isn't this a device or protocol defined datastructure? You can't just
change it like this.
next prev parent reply other threads:[~2018-12-12 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 6:24 Ashish Mhetre
2018-12-12 6:29 ` David Miller [this message]
2018-12-12 6:49 ` Sagi Grimberg
2018-12-12 7:45 ` Ashish Mhetre
2018-12-12 6:46 ` Sagi Grimberg
2018-12-12 7:51 ` Ard Biesheuvel
2018-12-12 8:06 ` Christoph Hellwig
2018-12-24 8:07 ` Ashish Mhetre
2018-12-14 14:13 ` kbuild test robot
2018-12-14 14:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211.222950.1995970751331458343.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Snikam@nvidia.com \
--cc=adrian.hunter@intel.com \
--cc=amhetre@nvidia.com \
--cc=axboe@kernel.dk \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=ulf.hansson@linaro.org \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®