From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC954C5CFFE for ; Tue, 11 Dec 2018 09:49:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A321E20811 for ; Tue, 11 Dec 2018 09:49:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="zDNqtc07" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A321E20811 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726250AbeLKJtE (ORCPT ); Tue, 11 Dec 2018 04:49:04 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:58086 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbeLKJtE (ORCPT ); Tue, 11 Dec 2018 04:49:04 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wBB9i1hO009006; Tue, 11 Dec 2018 09:48:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=XjFRVw8JIbcqD0DNsTFL7DcZxBNkKthVcwXo1XteKnE=; b=zDNqtc07zGygUcgky6YjVpWooaa2U/JOpw137Spq5QaP7BxJ9uQyioKRP9O0vtzUu4MQ y9uODH7iFxN7uBT0bVDofYp7QKx6I2z89V93/kPdaj8rQIxu+M0UbHHB0i1R7L79l/8q VgwQaTns+ABnTzzyEPsLOoNvJJpj0P80Wy5ajJ2vevRvbqrwEKfSZibeOFztrJbfhTF4 2g41EzHV+b0EihwMxOUKEHq+HLMCsU0VKD7dtN+iV7PQDTReon0mHgljYKPzaesFqTGU kNYB1q2EoMv96kd+MgrVUkIK1LTNQX1rTfK2MWOYLPCYno834IZlkQYaggCp+3xe67hG DA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2p85cu2vpt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Dec 2018 09:48:32 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wBB9mRqL010124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Dec 2018 09:48:27 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wBB9mPbs013418; Tue, 11 Dec 2018 09:48:26 GMT Received: from kadam (/10.175.35.120) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 11 Dec 2018 01:48:25 -0800 Date: Tue, 11 Dec 2018 12:48:12 +0300 From: Dan Carpenter To: Colin King Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][clk-next] clk: imx: remove redundant initialization of ret to zero Message-ID: <20181211094812.GB3116@kadam> References: <20181209150832.9366-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181209150832.9366-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9103 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=903 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812110092 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 09, 2018 at 03:08:32PM +0000, Colin King wrote: > From: Colin Ian King > > The initialization of ret is redundant as it is being re-assigned to > the return value from the call to imx8m_clk_composite_compute_dividers. > Clean this up by removing the initialization. > Just curious, is there a static checker which complains about this as dead code? regards, dan carpenter