From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A4CEC5CFFE for ; Tue, 11 Dec 2018 10:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2734C2081B for ; Tue, 11 Dec 2018 10:50:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2734C2081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbeLKKub (ORCPT ); Tue, 11 Dec 2018 05:50:31 -0500 Received: from mga03.intel.com ([134.134.136.65]:10798 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbeLKKub (ORCPT ); Tue, 11 Dec 2018 05:50:31 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2018 02:50:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,342,1539673200"; d="scan'208";a="258524757" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga004.jf.intel.com with ESMTP; 11 Dec 2018 02:50:28 -0800 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1gWfcR-00077c-Mp; Tue, 11 Dec 2018 12:50:27 +0200 Date: Tue, 11 Dec 2018 12:50:27 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: Ajay Gupta , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: nvidia-gpu: mark resume function as __maybe_unused Message-ID: <20181211105027.GB10650@smile.fi.intel.com> References: <20181210205356.2846843-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181210205356.2846843-1-arnd@arndb.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 10, 2018 at 09:53:45PM +0100, Arnd Bergmann wrote: > When CONFIG_PM is disabled, this is needed to avoid a harmless > unused-function warning: > > drivers/i2c/busses/i2c-nvidia-gpu.c:345:12: error: 'gpu_i2c_resume' defined but not used [-Werror=unused-function] > FWIW, Reviewed-by: Andy Shevchenko > Fixes: c71bcdcb42a7 ("i2c: add i2c bus driver for NVIDIA GPU") > Signed-off-by: Arnd Bergmann > --- > drivers/i2c/busses/i2c-nvidia-gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c > index e99c3bb58351..4e67d5ed480e 100644 > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c > @@ -342,7 +342,7 @@ static void gpu_i2c_remove(struct pci_dev *pdev) > pci_free_irq_vectors(pdev); > } > > -static int gpu_i2c_resume(struct device *dev) > +static __maybe_unused int gpu_i2c_resume(struct device *dev) > { > struct gpu_i2c_dev *i2cd = dev_get_drvdata(dev); > > -- > 2.20.0 > -- With Best Regards, Andy Shevchenko