From: Neil Horman <nhorman@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: lucien.xin@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
marcelo.leitner@gmail.com, dave.hansen@linux.intel.com,
rientjes@google.com, eparis@redhat.com, khorenko@virtuozzo.com
Subject: Re: [PATCHv2 net 0/3] net: add support for flex_array_resize in flex_array
Date: Wed, 12 Dec 2018 07:00:15 -0500 [thread overview]
Message-ID: <20181212120015.GA7637@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20181211.225000.726755542677275663.davem@davemloft.net>
On Tue, Dec 11, 2018 at 10:50:00PM -0800, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Fri, 7 Dec 2018 14:30:32 +0800
>
> > Without the support for the total_nr_elements's growing or shrinking
> > dynamically, flex_array is not that 'flexible'. Like when users want
> > to change the size, they have to redo flex_array_alloc and copy all
> > the elements from the old to the new one. The worse thing is every
> > element's memory gets changed.
> >
> > To implement flex_array_resize based on current code, the difficult
> > thing is to process the size border of FLEX_ARRAY_BASE_BYTES_LEFT,
> > where the base data memory may change to an array for the 2nd level
> > data memory for growing, likewise for shrinking.
> >
> > To make this part easier, we separate the base data memory and define
> > FLEX_ARRAY_BASE_SIZE as a same value of FLEX_ARRAY_PART_SIZE, as Neil
> > suggested. When new size is crossing the border, the base memory is
> > allocated as the array for the 2nd level data memory and its part[0]
> > is pointed to the old base memory, and do the opposite for shrinking.
> >
> > But it doesn't do any memory allocation or shrinking for elements in
> > flex_array_resize, as which should be done by flex_array_prealloc or
> > flex_array_shrink called by users. No memory leaks can be caused by
> > that.
> >
> > SCTP has benefited a lot from flex_array_resize() for managing its
> > stream memory so far.
> >
> > v1->v2:
> > Cc LKML and more developers.
>
> So I don't know what to do about this series.
>
> One of the responses stated that it has been proposed to remove flex_array
> and I don't know what to make of that, nor can I tell if that makes this
> series inappropriate or not.
>
I suggest xin respond to messageid 20180523011821.12165-6-kent.overstreet@gmail.com>
and send a NAK, indicating that his patch seems like it will break the build,
as, looking through it, it never removes flex_array calls from the sctp code.
If kent reposts with a conversion of the sctp code to radix trees, we're done.
If not, you can move forward with this commit.
Neil
next prev parent reply other threads:[~2018-12-12 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 6:30 Xin Long
2018-12-07 6:30 ` [PATCHv2 net 1/3] flex_array: make FLEX_ARRAY_BASE_SIZE the same value of FLEX_ARRAY_PART_SIZE Xin Long
2018-12-07 6:30 ` [PATCHv2 net 2/3] flex_array: support flex_array_resize Xin Long
2018-12-07 6:30 ` [PATCHv2 net 3/3] sctp: fa_resize sctp stream instead of redo fa_alloc Xin Long
2018-12-07 18:10 ` [PATCHv2 net 0/3] net: add support for flex_array_resize in flex_array Dave Hansen
2018-12-12 6:50 ` David Miller
2018-12-12 12:00 ` Neil Horman [this message]
2018-12-13 0:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212120015.GA7637@hmswarspite.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=khorenko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®