From: tom burkart <tom@aussec.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, lukas@fridolin.com
Subject: Re: [PATCH v9 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation
Date: Wed, 12 Dec 2018 13:25:51 +1100 [thread overview]
Message-ID: <20181212132551.48881ybb96b2pay7@www.aussec.com> (raw)
In-Reply-To: <CAL_JsqK877WtcFDEVc-fqRu0nSJwpgGBNjuxH0yiN7uy1BBRbw@mail.gmail.com>
Quoting Rob Herring <robh@kernel.org>:
> On Mon, Dec 10, 2018 at 8:17 PM tom burkart <tom@aussec.com> wrote:
>>
>> Quoting Rob Herring <robh@kernel.org>:
>>
>> > On Mon, Nov 26, 2018 at 10:06 PM tom burkart <tom@aussec.com> wrote:
>> >>
>> >> Quoting Rob Herring <robh@kernel.org>:
>> >>
>> >> > On Thu, Nov 22, 2018 at 3:49 AM Tom Burkart <tom@aussec.com> wrote:
>> >> >>
>> >> >> This patch implements the device tree changes required for the pps
>> >> >> echo functionality for pps-gpio, that sysfs claims is available
>> >> >> already.
>> >> >>
>> >> >> This patch was originally written by Lukas Senger as part of a masters
>> >> >> thesis project and modified for inclusion into the linux kernel by Tom
>> >> >> Burkart.
>> >> >>
>> >> >> Signed-off-by: Lukas Senger <lukas@fridolin.com>
>> >> >> Signed-off-by: Tom Burkart <tom@aussec.com>
>> >> >> ---
>> >> >> Documentation/devicetree/bindings/pps/pps-gpio.txt | 9 +++++++++
>> >> >> 1 file changed, 9 insertions(+)
>> >> >>
>> >> >> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> >> >> b/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> >> >> index 1155d49c2699..e09f6f2405c5 100644
>> >> >> --- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> >> >> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
>> >> >> @@ -7,10 +7,15 @@ Required properties:
>> >> >> - compatible: should be "pps-gpio"
>> >> >> - gpios: one PPS GPIO in the format described by ../gpio/gpio.txt
>> >> >>
>> >> >> +Additional required properties for the PPS ECHO functionality:
>> >> >> +- echo-gpios: one PPS ECHO GPIO in the format described by
>> >> ../gpio/gpio.txt
>> >> >> +- echo-active-ms: duration in ms of the active portion of
>> the echo pulse
>> >> >> +
>> >> >> Optional properties:
>> >> >> - assert-falling-edge: when present, assert is indicated by a
>> >> falling edge
>> >> >> (instead of by a rising edge)
>> >> >> - capture-clear: when present, also capture the PPS clear event
>> >> >> +- invert-pps-echo: when present, invert the PPS ECHO pulse
>> >> >
>> >> > Why do you need this? Can't you just make the echo gpio
>> GPIO_ACTIVE_LOW?
>> >> >
>> >> > BTW, using the flag probably should have been done for
>> >> > 'assert-falling-edge' as well.
>> >>
>> >> The hardware I use expects a positive-going echo pulse, however, it
>> >> was really easy to give users the option to have it inverted in case
>> >> they use different hardware that expects a negative-going edge.
>> >
>> > It will be even easier to implement if you use GPIO_ACTIVE_LOW or
>> > GPIO_ACTIVE_HIGH as appropriate. If the flag is set appropriately,
>> > then gpiod_set_value(gpio, 1) asserts the pulse and
>> > gpiod_set_value(gpio, 0) deasserts it no matter which way the h/w is
>> > wired. You can then get rid of invert_pps_echo in the driver.
>>
>> Hi Rob,
>> I have looked at the appropriate changes to my code to implement the
>> above. However, there is no GPIO_ACTIVE_* as part of the gpiod_flags
>> enum (include/linux/gpio/consumer.h).
>>
>> What am I missing?
>
> You don't need to know in the driver. You set the gpio state to 1 for
> active, 0 for inactive and that does the right thing based on the flag
> in the DT. IOW, if the DT defines the GPIO as active low, then setting
> the gpio state to 1 will result in the GPIO being 0V. It's a bit
> annoying and confusing at first until you realize the driver can just
> handle either polarity transparently.
Hi Rob,
thanks a lot! The penny finally dropped.
My patch v12 will have the changes implemented (no invert-pps-echo).
Tom
prev parent reply other threads:[~2018-12-12 2:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 9:45 [PATCH v9 0/4] PPS: " Tom Burkart
2018-11-22 9:45 ` [PATCH v9 1/4] dt-bindings: pps: capture-clear addition Tom Burkart
2018-11-22 9:46 ` [PATCH v9 2/4] pps: descriptor-based gpio, " Tom Burkart
2018-11-22 9:46 ` [PATCH v9 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation Tom Burkart
2018-11-22 9:46 ` [PATCH v9 4/4] pps: pps-gpio pps-echo implementation Tom Burkart
2018-11-26 19:42 ` [PATCH v9 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation Rob Herring
2018-11-27 4:06 ` tom burkart
2018-12-07 17:06 ` Rob Herring
2018-12-09 3:07 ` tom burkart
2018-12-11 2:17 ` tom burkart
2018-12-11 15:29 ` Rob Herring
2018-12-12 2:25 ` tom burkart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212132551.48881ybb96b2pay7@www.aussec.com \
--to=tom@aussec.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@fridolin.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®