From: Anders Roxell <anders.roxell@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de,
mingo@redhat.com, rostedt@goodmis.org, akpm@linux-foundation.org,
broonie@kernel.org, Anders Roxell <anders.roxell@linaro.org>
Subject: [RFC PATCH 2/3] lib/ubsan: default UBSAN_ALIGNMENT to not set
Date: Thu, 13 Dec 2018 13:29:09 +0100 [thread overview]
Message-ID: <20181213122910.24193-3-anders.roxell@linaro.org> (raw)
In-Reply-To: <20181213122910.24193-1-anders.roxell@linaro.org>
When booting an allmodconfig kernel, there are a lot of false-positives.
With a message like this 'UBSAN: Undefined behaviour in...' with a call
trace that follows.
Reworked so that when building a allmodconfig kernel that turns
everything into '=m' or '=y' will turn off UBSAN_ALIGNMENT.
Co-developed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
lib/Kconfig.ubsan | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan
index 98fa559ebd80..a2ae4a8e4fa6 100644
--- a/lib/Kconfig.ubsan
+++ b/lib/Kconfig.ubsan
@@ -27,15 +27,19 @@ config UBSAN_SANITIZE_ALL
Enabling this option will get kernel image size increased
significantly.
-config UBSAN_ALIGNMENT
- bool "Enable checking of pointers alignment"
+config UBSAN_NO_ALIGNMENT
+ bool "Disable checking of pointers alignment"
depends on UBSAN
- default y if !HAVE_EFFICIENT_UNALIGNED_ACCESS
+ default y if HAVE_EFFICIENT_UNALIGNED_ACCESS
help
- This option enables detection of unaligned memory accesses.
- Enabling this option on architectures that support unaligned
+ This option disables the check of unaligned memory accesses.
+ This option should be used when building allmodconfig.
+ Disabling this option on architectures that support unaligned
accesses may produce a lot of false positives.
+config UBSAN_ALIGNMENT
+ def_bool !UBSAN_NO_ALIGNMENT
+
config TEST_UBSAN
tristate "Module for testing for undefined behavior detection"
depends on m && UBSAN
--
2.19.2
next prev parent reply other threads:[~2018-12-13 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 12:29 [RFC PATCH 0/3] Make allmodconfig boot in qemu-arm64 Anders Roxell
2018-12-13 12:29 ` [RFC PATCH 1/3] config: provide a fragment to enable gdb for qemu Anders Roxell
2018-12-13 12:40 ` Mark Brown
2018-12-18 8:45 ` Anders Roxell
2018-12-18 9:07 ` Arnd Bergmann
2018-12-18 13:29 ` Mark Brown
2018-12-13 12:29 ` Anders Roxell [this message]
2018-12-13 12:29 ` [RFC PATCH 3/3] arm64: add a new config option KTEST_RUNNABLE Anders Roxell
2018-12-13 15:18 ` Mark Brown
2019-01-07 14:39 ` Mark Rutland
2019-01-07 14:43 ` Mark Rutland
2019-01-07 17:55 ` Mark Brown
2019-01-07 17:59 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213122910.24193-3-anders.roxell@linaro.org \
--to=anders.roxell@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®