Re: [PATCH] regulator/of_get_regulator: add child path to find the regulator supplier

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

On Thu, Nov 08, 2018 at 01:40:35PM +0800, zoro wrote:

>             ldo0_vir: ldo0-virtual {

>             ldo1_vir: ldo1-virtual {
>                 regulator-compatible = "VIR_LDO1";
>                 regulator-name= "VIR_LDO1";
>                 regulator-min-microvolt = <1000000>;
>                 regulator-max-microvolt = <3000000>;
>                 ldo1-supply = <&ldo0_vir>;

> when the VIR_LDO1 regulator supplier is it's brother,
> we can't find the supplier.
> so we add the child ptah to find the suppier.

The supplies for the chip (even if they happen to be supplies for a
regulator on the chip) are supposed to be defined at the chip level so
your ldo1-supply property ought to be at the top level for the chip, not
in the individual regulator node.  This keeps the regulator supplies
consistent with other supplies and is especially useful if a single
physical input is used by multiple things.  As far as I can tell the
issue isn't the fact that the parent regulator is defined as part of the
same chip, it's where the supply property that LDO1 is looking up has
been placed in the DT.

Sorry for the delayed response here, I had some travel and it took a
while to figure out what was going on with this change.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]